Merge lp:~barry/launchpad/474269-actions into lp:launchpad
Proposed by
Barry Warsaw
Status: | Merged |
---|---|
Approved by: | Barry Warsaw |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~barry/launchpad/474269-actions |
Merge into: | lp:launchpad |
Diff against target: |
30 lines 1 file modified
lib/lp/registry/templates/person-edit.pt (+0/-20) |
To merge this branch: | bzr merge lp:~barry/launchpad/474269-actions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email:
|
To post a comment you must log in.
= Summary =
Bug 474269 describes a ui clean up where the ~person/+edit page has an
extraneous menu at the bottom of the page. The menu contains
* Set preferred languages
* Update wiki names
* Update IRC nicknames
* Update Jabber IDs
As all are available for editing on the ~person's index page, this menu is no
longer needed.
== Proposed fix ==
Remove the template code that renders this menu.
== Pre-implementation notes ==
None.
== Implementation details ==
None.
== Tests ==
% bin/test -vv -t person
== Demo and Q/A ==
* Login as admin launchpad. dev/~name12/ +edit
* Visit http://
* Scroll to the bottom of the page; no menu
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ templates/ person- edit.pt
lib/lp/