Merge lp:~barry/launchpad/474269-actions into lp:launchpad

Proposed by Barry Warsaw
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~barry/launchpad/474269-actions
Merge into: lp:launchpad
Diff against target: 30 lines
1 file modified
lib/lp/registry/templates/person-edit.pt (+0/-20)
To merge this branch: bzr merge lp:~barry/launchpad/474269-actions
Reviewer Review Type Date Requested Status
Abel Deuring (community) code Approve
Review via email: mp+14440@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

= Summary =

Bug 474269 describes a ui clean up where the ~person/+edit page has an
extraneous menu at the bottom of the page. The menu contains

 * Set preferred languages
 * Update wiki names
 * Update IRC nicknames
 * Update Jabber IDs

As all are available for editing on the ~person's index page, this menu is no
longer needed.

== Proposed fix ==

Remove the template code that renders this menu.

== Pre-implementation notes ==

None.

== Implementation details ==

None.

== Tests ==

% bin/test -vv -t person

== Demo and Q/A ==

 * Login as admin
 * Visit http://launchpad.dev/~name12/+edit
 * Scroll to the bottom of the page; no menu

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/person-edit.pt

Revision history for this message
Abel Deuring (adeuring) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/templates/person-edit.pt'
--- lib/lp/registry/templates/person-edit.pt 2009-09-17 18:48:15 +0000
+++ lib/lp/registry/templates/person-edit.pt 2009-11-04 20:55:21 +0000
@@ -17,26 +17,6 @@
17 replace="structure view/i_know_this_is_an_openid_security_issue_input|nothing" />17 replace="structure view/i_know_this_is_an_openid_security_issue_input|nothing" />
18 </metal:other_input>18 </metal:other_input>
19 </div>19 </div>
20
21 <h2 style="margin-top: 2em;">Other actions</h2>
22 <ul style="list-style-type:none; padding-left:1.5em;">
23 <li
24 tal:content="structure overview_menu/editlanguages/fmt:link-icon">
25 Set your preferred language
26 </li>
27 <li
28 tal:content="structure overview_menu/editwikinames/fmt:link-icon">
29 Edit your wiki names
30 </li>
31 <li
32 tal:content="structure overview_menu/editircnicknames/fmt:link-icon">
33 Edit your IRC contact names
34 </li>
35 <li
36 tal:content="structure overview_menu/editjabberids/fmt:link-icon">
37 Edit your Jabber contact names
38 </li>
39 </ul>
40 <p style="margin-top: 4em;">20 <p style="margin-top: 4em;">
41 Never going to use Launchpad again?21 Never going to use Launchpad again?
42 <a22 <a