Code review comment for lp:~barry/launchpad/416497-distros

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Barry,

again, a nice branch. Aside from my nitpick about the overly precise font size for .application-summary, I only noticed one "spurious change":

> === modified file 'lib/lp/registry/browser/person.py'
> --- lib/lp/registry/browser/person.py 2009-08-20 16:13:15 +0000
> +++ lib/lp/registry/browser/person.py 2009-08-20 22:57:10 +0000
> @@ -1337,6 +1337,7 @@
>
>
> class PersonSetActionNavigationMenu(RegistryCollectionActionMenuBase):
> +

please remove the empty line.

> """Action menu for `PeopleSearchView`."""
> usedfor = IPersonSet
> links = ['register_team', 'register_project', 'create_account',

Abel

review: Approve

« Back to merge proposal