Merge lp:~barry/errors/lp1543350 into lp:errors

[Barry Warsaw]

I liked Occurrences for the intro to the table, but it didn't look quite right for the column heading, so I chose Incident instead.

The branch can't be run on Xenial so I just loaded a real page and hacked it using chromium developer mode!

[Martin Pitt (pitti)]

Can we have some consistency between the two different labels? I. e. pick "Incident" or "Occurrences".

[Brian Murray (brian-murray)]

I can see "Occurrences" as a collection of things, so don't mind the different labels since one is for the table and one is for the column.

[Barry Warsaw (barry)]

Concur with Brian.

[Brian Murray (brian-murray)]

I decided to rename the example key to make grep'ing for stuff easier but that was a whole of changes so I need to test it tomorrow.

[Barry Warsaw (barry)]

I thought about that, but I went for a minimal change for exactly that reason.

[Brian Murray (brian-murray)]

A minimal change would have certainly caused me less pain. I ran into an issue with renaming the examples div and the timestamp column ending up being very wide so I just dropped that.

review: Approve

=== modified file 'errors/templates/bucket.html'
--- errors/templates/bucket.html	2016-03-16 13:31:52 +0000
+++ errors/templates/bucket.html	2016-03-16 21:29:55 +0000
@@ -210,7 +210,7 @@
             /* Set up the examples table. */
             var cols = [
             {key: "timestamp", label: "Time", formatter: formatDates},
-            {key: "example", label: "Example", formatter: formatExample, allowHTML: true},
+            {key: "example", label: "Incident", formatter: formatExample, allowHTML: true},
             {key: "package_version", label: "Package version"},
             {key: "ubuntu_version", label: "Ubuntu release"},
             {key: "architecture", label: "Architecture"},
@@ -313,7 +313,7 @@
         {{ traceback|pygmentize:"pytb"|safe }}
     {% endif %}
 {% endif %}
-<h3>Examples</h3>
+<h3>Occurrences</h3>
 <div id="examples_group">
     <div id="examples"></div>
     <div id="spinner"></div>