Code review comment for lp:~banking-addons-drivers/banking-addons/direct-debit-refactoring-fosdem

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks, looks really good.

About the auto_install values: I think the one in line 103 was a copy/paste error when account_banking_payment_export was split off from account_banking_payment. However, the one in account_banking_payment was always there on purpose as it made sense to install the payment part of account_banking when both account_banking and account_payment were installed. I think it still makes sense with the new dependencies account_banking and account_banking_payment_export, so I'd like to keep the one in line 36.

review: Needs Fixing

« Back to merge proposal