charm-k8s-mm-pd-bot

Code review comment for ~ballot/charm-k8s-mm-pd-bot/+git/charm-k8s-mm-pd-bot:cleaning

  1. Git
  2. lp:~ballot/charm-k8s-mm-pd-bot/+git/charm-k8s-mm-pd-bot
  3. cleaning
  4. Merge into master
Revision history for this message
Tom Haddon (mthaddon) wrote :

A few comments inline (nothing major).

It seems `make test` doesn't include lint, which was somewhat unexpected. `make lint` also fails as follows:

https://paste.ubuntu.com/p/P5FPFH9vh3/

Also, you're missing a commit message for this MP.

review: Needs Fixing

« Back to merge proposal