Merge lp:~ballogy/overlay-scrollbar/make-tests-optional into lp:overlay-scrollbar

Proposed by Balló György
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 317
Merged at revision: 322
Proposed branch: lp:~ballogy/overlay-scrollbar/make-tests-optional
Merge into: lp:overlay-scrollbar
Diff against target: 42 lines (+12/-2)
2 files modified
Makefile.am (+5/-2)
configure.ac (+7/-0)
To merge this branch: bzr merge lp:~ballogy/overlay-scrollbar/make-tests-optional
Reviewer Review Type Date Requested Status
Ayatana Scrollbar Team Pending
Review via email: mp+83502@code.launchpad.net

Description of the change

This change makes it possible to disable building tests with '--disable-tests' configure switch.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

I'd rather use a different name instead WANT_TESTS... I don't know, ENABLE_TESTS or DISABLE_TESTS?

Revision history for this message
Andrea Cimitan (cimi) wrote :

Or others... but thanks, looks nice!

Revision history for this message
Andrea Cimitan (cimi) wrote :

Merged with ENABLE_TESTS

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2011-04-21 14:33:22 +0000
+++ Makefile.am 2011-11-27 02:22:02 +0000
@@ -3,8 +3,11 @@
3 data \3 data \
4 build \4 build \
5 pkgconfig \5 pkgconfig \
6 os \6 os
7 tests7
8if WANT_TESTS
9SUBDIRS += tests
10endif
811
9ACLOCAL_AMFLAGS = -I build12ACLOCAL_AMFLAGS = -I build
1013
1114
=== modified file 'configure.ac'
--- configure.ac 2011-10-19 15:35:09 +0000
+++ configure.ac 2011-11-27 02:22:02 +0000
@@ -88,6 +88,12 @@
88)88)
89AM_CONDITIONAL(USE_GTK3, [test "x$with_gtk" = x3])89AM_CONDITIONAL(USE_GTK3, [test "x$with_gtk" = x3])
9090
91# Check if build tests
92AC_ARG_ENABLE([tests],
93 AC_HELP_STRING([--disable-tests], [Disable tests]),,
94 [enable_tests=yes])
95AM_CONDITIONAL([WANT_TESTS], [test "x$enable_tests" != "xno"])
96
91# Debug flags97# Debug flags
9298
93if test x$OS_TRUNK = xyes; then99if test x$OS_TRUNK = xyes; then
@@ -171,6 +177,7 @@
171echo " ========================="177echo " ========================="
172echo ""178echo ""
173echo " Gtk+: ${with_gtk}"179echo " Gtk+: ${with_gtk}"
180echo " Tests: ${enable_tests}"
174echo " Debug: ${enable_debug}"181echo " Debug: ${enable_debug}"
175echo " Prefix: ${prefix}"182echo " Prefix: ${prefix}"
176echo ""183echo ""

Subscribers

People subscribed via source and target branches