Merge lp:~ballogy/libindicate/diff-dir-for-gtk3 into lp:libindicate/0.7

Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 440
Merged at revision: 439
Proposed branch: lp:~ballogy/libindicate/diff-dir-for-gtk3
Merge into: lp:libindicate/0.7
Diff against target: 37 lines (+3/-3)
3 files modified
libindicate-gtk/Makefile.am (+1/-1)
libindicate-gtk/indicate-gtk-0.6.pc.in (+1/-1)
libindicate-gtk/indicate-gtk3-0.6.pc.in (+1/-1)
To merge this branch: bzr merge lp:~ballogy/libindicate/diff-dir-for-gtk3
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+92311@code.launchpad.net

This proposal supersedes a proposal from 2011-11-21.

Description of the change

Currently, both GTK2 and GTK3 build install header files into the same directory (/usr/include/libindicate-0.6). This causes conflict between the two package if the header files are packaged together with binaries (e.g. on Arch Linux).

This change modify the location of header files for GTK3 library.

To post a comment you must log in.
Revision history for this message
Balló György (ballogy) wrote : Posted in a previous version of this proposal

Now I modified my proposal to use three different top-level header location for libindicate, libindicate-gtk and libindicate-gtk3.

Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libindicate-gtk/Makefile.am'
--- libindicate-gtk/Makefile.am 2011-08-10 18:40:09 +0000
+++ libindicate-gtk/Makefile.am 2012-02-09 16:33:46 +0000
@@ -20,7 +20,7 @@
20 indicate-gtk-0.6.pc.in \20 indicate-gtk-0.6.pc.in \
21 indicate-gtk3-0.6.pc.in21 indicate-gtk3-0.6.pc.in
2222
23libindicate_gtkincludedir=$(includedir)/libindicate-0.6/libindicate-gtk23libindicate_gtkincludedir=$(includedir)/libindicate-gtk$(VER)-0.6/libindicate-gtk
2424
25indicate_gtk_headers = \25indicate_gtk_headers = \
26 indicator.h \26 indicator.h \
2727
=== modified file 'libindicate-gtk/indicate-gtk-0.6.pc.in'
--- libindicate-gtk/indicate-gtk-0.6.pc.in 2011-08-11 03:03:27 +0000
+++ libindicate-gtk/indicate-gtk-0.6.pc.in 2012-02-09 16:33:46 +0000
@@ -4,7 +4,7 @@
4bindir=@bindir@4bindir=@bindir@
5includedir=@includedir@5includedir=@includedir@
66
7Cflags: -I${includedir}/libindicate-0.67Cflags: -I${includedir}/libindicate-gtk-0.6
8Requires: gtk+-2.0 indicate-0.68Requires: gtk+-2.0 indicate-0.6
9Libs: -L${libdir} -lindicate-gtk9Libs: -L${libdir} -lindicate-gtk
1010
1111
=== modified file 'libindicate-gtk/indicate-gtk3-0.6.pc.in'
--- libindicate-gtk/indicate-gtk3-0.6.pc.in 2011-08-11 03:03:27 +0000
+++ libindicate-gtk/indicate-gtk3-0.6.pc.in 2012-02-09 16:33:46 +0000
@@ -4,7 +4,7 @@
4bindir=@bindir@4bindir=@bindir@
5includedir=@includedir@5includedir=@includedir@
66
7Cflags: -I${includedir}/libindicate-0.67Cflags: -I${includedir}/libindicate-gtk3-0.6
8Requires: gtk+-3.0 indicate-0.68Requires: gtk+-3.0 indicate-0.6
9Libs: -L${libdir} -lindicate-gtk39Libs: -L${libdir} -lindicate-gtk3
1010

Subscribers

People subscribed via source and target branches