Merge lp:~ballogy/libappindicator/build-fixes into lp:libappindicator

Proposed by Balló György
Status: Superseded
Proposed branch: lp:~ballogy/libappindicator/build-fixes
Merge into: lp:libappindicator
Diff against target: 50 lines (+4/-4)
4 files modified
bindings/mono/Makefile.am (+1/-1)
bindings/mono/appindicator-sharp-0.1.pc.in (+1/-1)
bindings/python/Makefile.am (+1/-1)
src/appindicator3-0.1.pc.in (+1/-1)
To merge this branch: bzr merge lp:~ballogy/libappindicator/build-fixes
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+83076@code.launchpad.net

This proposal has been superseded by a proposal from 2012-01-27.

Description of the change

This change contains some build fixes for the following problems:

1. Currently, the header files of GTK3 version of the library installed into /usr/include/libappindicator3-0.1 directory, but /usr/include/libappindicator-0.1 defined in appindicator3-0.1.pc.

2. Do not link pyglib explicitly, because the name of the pyglib library may differ between systems, and it seems that it builds without explicit linking.

3. Currently, mono files are installed into a non-standard /usr/lib/cli/appindicator-sharp-0.1 directory instead of /usr/lib/mono/appindicator-sharp. (Debian/Ubuntu should use a distro specific downstream patch.)

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bindings/mono/Makefile.am'
--- bindings/mono/Makefile.am 2011-02-24 04:46:17 +0000
+++ bindings/mono/Makefile.am 2011-11-22 21:38:25 +0000
@@ -29,7 +29,7 @@
29 $(DLLPOLICY1) \29 $(DLLPOLICY1) \
30 $(POLICY1).config30 $(POLICY1).config
3131
32assemblydir = $(libdir)/cli/appindicator-sharp-0.132assemblydir = $(libdir)/mono/appindicator-sharp
33assembly_DATA = $(TARGET)33assembly_DATA = $(TARGET)
3434
35CLEANFILES = \35CLEANFILES = \
3636
=== modified file 'bindings/mono/appindicator-sharp-0.1.pc.in'
--- bindings/mono/appindicator-sharp-0.1.pc.in 2010-05-23 10:44:53 +0000
+++ bindings/mono/appindicator-sharp-0.1.pc.in 2011-11-22 21:38:25 +0000
@@ -1,7 +1,7 @@
1prefix=@prefix@1prefix=@prefix@
2exec_prefix=@exec_prefix@2exec_prefix=@exec_prefix@
3libdir=@libdir@3libdir=@libdir@
4assemblies_dir=${libdir}/cli/appindicator-sharp-0.14assemblies_dir=${libdir}/mono/appindicator-sharp
55
6Name: appindicator-sharp6Name: appindicator-sharp
7Description: application indicators for .NET7Description: application indicators for .NET
88
=== modified file 'bindings/python/Makefile.am'
--- bindings/python/Makefile.am 2009-12-12 02:29:28 +0000
+++ bindings/python/Makefile.am 2011-11-22 21:38:25 +0000
@@ -19,7 +19,7 @@
19appindicatordir = $(pkgpyexecdir)/appindicator19appindicatordir = $(pkgpyexecdir)/appindicator
20appindicator_LTLIBRARIES = _appindicator.la20appindicator_LTLIBRARIES = _appindicator.la
2121
22_appindicator_la_LDFLAGS = -module -avoid-version -export-symbols-regex init_appindicator -lpyglib-2.0-python2.622_appindicator_la_LDFLAGS = -module -avoid-version -export-symbols-regex init_appindicator
23_appindicator_la_LIBADD = $(APPINDICATOR_PYTHON_LIBS) -L$(top_builddir)/src/.libs -lappindicator23_appindicator_la_LIBADD = $(APPINDICATOR_PYTHON_LIBS) -L$(top_builddir)/src/.libs -lappindicator
24_appindicator_la_SOURCES = appindicatormodule.c24_appindicator_la_SOURCES = appindicatormodule.c
25nodist__appindicator_la_SOURCES = appindicator.c25nodist__appindicator_la_SOURCES = appindicator.c
2626
=== modified file 'src/appindicator3-0.1.pc.in'
--- src/appindicator3-0.1.pc.in 2011-03-01 04:34:45 +0000
+++ src/appindicator3-0.1.pc.in 2011-11-22 21:38:25 +0000
@@ -4,7 +4,7 @@
4bindir=@bindir@4bindir=@bindir@
5includedir=@includedir@5includedir=@includedir@
66
7Cflags: -I${includedir}/libappindicator-0.17Cflags: -I${includedir}/libappindicator3-0.1
8Requires: dbusmenu-glib-0.4 gtk+-3.08Requires: dbusmenu-glib-0.4 gtk+-3.0
9Libs: -L${libdir} -lappindicator39Libs: -L${libdir} -lappindicator3
1010

Subscribers

People subscribed via source and target branches