Code review comment for lp:~ballogy/indicator-sound/fix-playlist-icon

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Mathieu, I doubt very much that there was a good reason for the playlist icon to be called "sound-icon". First, it doesn't include the word "playlist", which it obviously should. And second, it includes the word "icon", which is redundant. However, I agree that it would be more reassuring if there was a bug report (with screenshots) demonstrating the problem being fixed here.

Furthermore, it's inappropriate for the menu to be using symbolic icons in the first place. Ideally, it should use the same playlist icons as the music player itself does.

« Back to merge proposal