Merge lp:~ballogy/gloobus-preview/fix-threading into lp:gloobus-preview

Proposed by Balló György
Status: Merged
Merged at revision: 295
Proposed branch: lp:~ballogy/gloobus-preview/fix-threading
Merge into: lp:gloobus-preview
Diff against target: 55 lines (+5/-0)
4 files modified
configure.ac (+1/-0)
src/Makefile.am (+2/-0)
src/gloobus-preview-main.cpp (+1/-0)
src/gloobus-preview-singleton.h (+1/-0)
To merge this branch: bzr merge lp:~ballogy/gloobus-preview/fix-threading
Reviewer Review Type Date Requested Status
Gloobus Developers Pending
Review via email: mp+245305@code.launchpad.net

Description of the change

Avoid X11 threading errors

Without calling XInitThreads, videos crash the application occasionally, when open them. More info:
http://stackoverflow.com/questions/18647475/threading-problems-with-gtk

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2012-05-13 19:48:02 +0000
+++ configure.ac 2014-12-22 06:35:31 +0000
@@ -55,6 +55,7 @@
55PKG_CHECK_MODULES(FREETYPE,freetype2)55PKG_CHECK_MODULES(FREETYPE,freetype2)
56PKG_CHECK_MODULES(GLIB, glib-2.0)56PKG_CHECK_MODULES(GLIB, glib-2.0)
57PKG_CHECK_MODULES(DBUS, dbus-glib-1)57PKG_CHECK_MODULES(DBUS, dbus-glib-1)
58PKG_CHECK_MODULES(X11, x11)
5859
59PKG_CHECK_MODULES(GMODULE, gmodule-2.0) # To compile XCF loader60PKG_CHECK_MODULES(GMODULE, gmodule-2.0) # To compile XCF loader
60PKG_CHECK_MODULES(GDKPIXBUF, gdk-pixbuf-2.0) # To compile XCF loader61PKG_CHECK_MODULES(GDKPIXBUF, gdk-pixbuf-2.0) # To compile XCF loader
6162
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2011-11-01 02:03:33 +0000
+++ src/Makefile.am 2014-12-22 06:35:31 +0000
@@ -26,6 +26,7 @@
26 $(GTKSOURCEVIEW_CFLAGS) \26 $(GTKSOURCEVIEW_CFLAGS) \
27 $(GLIB_CFLAGS) \27 $(GLIB_CFLAGS) \
28 $(DBUS_CFLAGS) \28 $(DBUS_CFLAGS) \
29 $(X11_CFLAGS) \
29 $(BOOST_CPPFLAGS)30 $(BOOST_CPPFLAGS)
3031
31AM_LDADD = \32AM_LDADD = \
@@ -36,6 +37,7 @@
36 $(GTKSOURCEVIEW_LIBS) \37 $(GTKSOURCEVIEW_LIBS) \
37 $(GLIB_LIBS) \38 $(GLIB_LIBS) \
38 $(DBUS_LIBS) \39 $(DBUS_LIBS) \
40 $(X11_LIBS) \
39 -ldl41 -ldl
4042
41bin_PROGRAMS = gloobus-preview43bin_PROGRAMS = gloobus-preview
4244
=== modified file 'src/gloobus-preview-main.cpp'
--- src/gloobus-preview-main.cpp 2010-05-16 12:33:24 +0000
+++ src/gloobus-preview-main.cpp 2014-12-22 06:35:31 +0000
@@ -43,6 +43,7 @@
4343
44 //g_thread_init(NULL);44 //g_thread_init(NULL);
45 //gdk_threads_init();45 //gdk_threads_init();
46 XInitThreads();
46 gtk_init (&argc, &argv);47 gtk_init (&argc, &argv);
47 //gtk_rc_parse(PACKAGE_DATA_PATH "/gtkrc/customgtk.rc");48 //gtk_rc_parse(PACKAGE_DATA_PATH "/gtkrc/customgtk.rc");
4849
4950
=== modified file 'src/gloobus-preview-singleton.h'
--- src/gloobus-preview-singleton.h 2011-10-30 20:42:38 +0000
+++ src/gloobus-preview-singleton.h 2014-12-22 06:35:31 +0000
@@ -35,6 +35,7 @@
35#include <vector>35#include <vector>
36#include <gtk/gtk.h>36#include <gtk/gtk.h>
37#include <gdk/gdkkeysyms.h>37#include <gdk/gdkkeysyms.h>
38#include <X11/Xlib.h>
3839
39#include "gloobus-preview-config.h"40#include "gloobus-preview-config.h"
40#include "gloobus-preview-defines.h"41#include "gloobus-preview-defines.h"

Subscribers

People subscribed via source and target branches