Code review comment for lp:~ballogy/docky/systemd-support

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Thanks for this!

There are some things needs to be changed.
It is better to do the icon fixing in another branch since what you have done isn't enough yet.
Use string.Equals for checking equality of strings.
Using "No session bus available" suggests it is a dbus-related problem, so "No consolekit or systemd bus available" is better.

review: Needs Fixing

« Back to merge proposal