Qt bindings for libdee

Code review comment for lp:~ballogy/dee-qt/install-pkgconfig-file

  1. install-pkgconfig-file
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

This looks good, thanks György. One remark, and one tiny thing to fix before we can merge it:

 - The comment is useless: if the destination target is a relative path (which it is), it will be installed relative to ${CMAKE_INSTALL_PREFIX}. Please remove it.

 - The file debian/libqtdee-dev.install needs to be updated. The change would be something like:

    -libqtdee.pc usr/lib/pkgconfig/
    +usr/lib/pkgconfig/libqtdee.pc

review: Needs Fixing

« Back to merge proposal