Qt bindings for libbamf

Code review comment for lp:~ballogy/bamf-qt/fix-imports-dir-location

  1. fix-imports-dir-location
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

The change looks sound.
However I tested it on Ubuntu and it appears that cmake has a bug whereby QT_IMPORTS_DIR is not correctly defined (I reported it as bug #894805).
Therefore it cannot be merged as is. A possible solution would be to check for the value of ${QT_IMPORTS_DIR} and if it’s invalid (e.g. "QT_IMPORTS_DIR-NOTFOUND") fallback on the hardcoded value /usr/lib/qt4/imports. What do you think?

« Back to merge proposal