Code review comment for lp:~bac/lpsetup/setup_x

The attempt to merge lp:~bac/lpsetup/setup_x into lp:lpsetup failed. Below is the output from the failed tests.

lxc.aa_profile = lxc-container-with-nesting
WARNING: this command will destroy the 'lpsetup-testing-lxc' environment (type: local).
This includes all machines, services, data, and other resources. Continue [y/N]**********************************************************************
* Checking test environment. *
**********************************************************************
**********************************************************************
* Setting up the test environment for LXC container. *
**********************************************************************
----------------------------------------------------------------------
check_call:
juju bootstrap -e lpsetup-testing-lxc
----------------------------------------------------------------------
**********************************************************************
None
**********************************************************************
**********************************************************************
* Cleaning up. *
**********************************************************************

**********************************************************************
* Run time: 0:02:26.380304 *
**********************************************************************

+ set -o errexit
++ grep -v distribute_setup.py
++ find . -name build -prune -o -name '*.py'
+ pyfiles='./setup.py
./lplxcip/tests/utils.py
./lplxcip/tests/__init__.py
./lplxcip/tests/test_lxcip.py
./lplxcip/tests/test_helpers.py
./lplxcip/tests/test_utils.py
./lplxcip/lxcip.py
./lpsetup/utils.py
./lpsetup/__init__.py
./lpsetup/handlers.py
./lpsetup/tests/utils.py
./lpsetup/tests/__init__.py
./lpsetup/tests/test_argparser.py
./lpsetup/tests/test_cli.py
./lpsetup/tests/test_handlers.py
./lpsetup/tests/subcommands/__init__.py
./lpsetup/tests/subcommands/test_version.py
./lpsetup/tests/subcommands/test_initrepo.py
./lpsetup/tests/subcommands/test_init_target.py
./lpsetup/tests/subcommands/test_smoke.py
./lpsetup/tests/integration/common.py
./lpsetup/tests/integration/test_install_lxc.py
./lpsetup/tests/integration/test_init_target.py
./lpsetup/tests/test_utils.py
./lpsetup/subcommands/__init__.py
./lpsetup/subcommands/install_lxc.py
./lpsetup/subcommands/initlxc.py
./lpsetup/subcommands/init_target.py
./lpsetup/subcommands/update.py
./lpsetup/subcommands/initrepo.py
./lpsetup/subcommands/version.py
./lpsetup/exceptions.py
./lpsetup/argparser.py
./lpsetup/settings.py
./lpsetup/cli.py'
+ pocketlint ./setup.py ./lplxcip/tests/utils.py ./lplxcip/tests/__init__.py ./lplxcip/tests/test_lxcip.py ./lplxcip/tests/test_helpers.py ./lplxcip/tests/test_utils.py ./lplxcip/lxcip.py ./lpsetup/utils.py ./lpsetup/__init__.py ./lpsetup/handlers.py ./lpsetup/tests/utils.py ./lpsetup/tests/__init__.py ./lpsetup/tests/test_argparser.py ./lpsetup/tests/test_cli.py ./lpsetup/tests/test_handlers.py ./lpsetup/tests/subcommands/__init__.py ./lpsetup/tests/subcommands/test_version.py ./lpsetup/tests/subcommands/test_initrepo.py ./lpsetup/tests/subcommands/test_init_target.py ./lpsetup/tests/subcommands/test_smoke.py ./lpsetup/tests/integration/common.py ./lpsetup/tests/integration/test_install_lxc.py ./lpsetup/tests/integration/test_init_target.py ./lpsetup/tests/test_utils.py ./lpsetup/subcommands/__init__.py ./lpsetup/subcommands/install_lxc.py ./lpsetup/subcommands/initlxc.py ./lpsetup/subcommands/init_target.py ./lpsetup/subcommands/update.py ./lpsetup/subcommands/initrepo.py ./lpsetup/subcommands/version.py ./lpsetup/exceptions.py ./lpsetup/argparser.py ./lpsetup/settings.py ./lpsetup/cli.py
+ pep8 --exclude=build ./setup.py ./lplxcip/tests/utils.py ./lplxcip/tests/__init__.py ./lplxcip/tests/test_lxcip.py ./lplxcip/tests/test_helpers.py ./lplxcip/tests/test_utils.py ./lplxcip/lxcip.py ./lpsetup/utils.py ./lpsetup/__init__.py ./lpsetup/handlers.py ./lpsetup/tests/utils.py ./lpsetup/tests/__init__.py ./lpsetup/tests/test_argparser.py ./lpsetup/tests/test_cli.py ./lpsetup/tests/test_handlers.py ./lpsetup/tests/subcommands/__init__.py ./lpsetup/tests/subcommands/test_version.py ./lpsetup/tests/subcommands/test_initrepo.py ./lpsetup/tests/subcommands/test_init_target.py ./lpsetup/tests/subcommands/test_smoke.py ./lpsetup/tests/integration/common.py ./lpsetup/tests/integration/test_install_lxc.py ./lpsetup/tests/integration/test_init_target.py ./lpsetup/tests/test_utils.py ./lpsetup/subcommands/__init__.py ./lpsetup/subcommands/install_lxc.py ./lpsetup/subcommands/initlxc.py ./lpsetup/subcommands/init_target.py ./lpsetup/subcommands/update.py ./lpsetup/subcommands/initrepo.py ./lpsetup/subcommands/version.py ./lpsetup/exceptions.py ./lpsetup/argparser.py ./lpsetup/settings.py ./lpsetup/cli.py
+ nosetests
........................................................................................................................................................................
Name Stmts Miss Cover Missing
---------------------------------------------------------------
lpsetup 6 0 100%
lpsetup.argparser 123 2 98% 226, 255
lpsetup.cli 79 8 90% 65-66, 83-85, 121-122, 179
lpsetup.exceptions 6 0 100%
lpsetup.handlers 96 1 99% 244
lpsetup.settings 33 0 100%
lpsetup.subcommands 0 0 100%
lpsetup.subcommands.init_target 136 54 60% 101, 138-142, 152-177, 198-205, 222-240, 246, 251-259, 268-278
lpsetup.subcommands.initlxc 91 44 52% 63-67, 82-126, 139, 146-147, 160-205, 214-217, 224-226
lpsetup.subcommands.initrepo 73 10 86% 64-66, 73, 78-80, 87-89
lpsetup.subcommands.install_lxc 66 34 48% 44-46, 55-81, 91-92, 98-107, 117-121, 131-140
lpsetup.subcommands.update 49 18 63% 34-35, 44-63, 74-75, 86-88
lpsetup.subcommands.version 11 0 100%
lpsetup.utils 190 41 78% 122, 189, 243-253, 268, 307-314, 336, 346, 362-370, 387-393, 408-410, 422-428
---------------------------------------------------------------
TOTAL 959 212 78%
----------------------------------------------------------------------
Ran 168 tests in 65.669s

OK
+ '[' --nested-mods == --nested-mods ']'
+ sudo bin/setup-host-for-nested-lxc-containers.sh
+ lpsetup/tests/integration/test_install_lxc.py
juju environment not found: no details available
2012-08-27 14:34:44,163 ERROR juju environment not found: no details available
2012-08-27 14:34:57,768 INFO Bootstrapping environment 'lpsetup-testing-lxc' (origin: distro type: local)...
2012-08-27 14:34:57,800 INFO Checking for required packages...
2012-08-27 14:35:56,711 INFO Starting networking...
2012-08-27 14:36:03,918 INFO Starting zookeeper...
2012-08-27 14:36:04,110 INFO Starting storage server...
could not connect before timeout
2012-08-27 14:36:34,579 ERROR could not connect before timeout
2012-08-27 14:36:35,424 INFO Destroying environment 'lpsetup-testing-lxc' (type: local)...
2012-08-27 14:36:35,424 INFO Destroying unit containers...
2012-08-27 14:36:37,628 INFO 'destroy_environment' command finished successfully
Traceback (most recent call last):
  File "lpsetup/tests/integration/test_install_lxc.py", line 91, in <module>
    sys.exit(InstallLXCTest().run())
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/tests/integration/common.py", line 137, in run
    self.set_up()
  File "lpsetup/tests/integration/test_install_lxc.py", line 62, in set_up
    super(InstallLXCTest, self).set_up()
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/tests/integration/common.py", line 83, in set_up
    self.check_call('juju bootstrap -e {}'.format(self.juju_env).split())
  File "/home/tarmac/repos/lpsetup/trunk/lpsetup/tests/integration/common.py", line 58, in check_call
    check_call_orig(*args)
  File "/usr/lib/python2.7/subprocess.py", line 511, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['juju', 'bootstrap', '-e', 'lpsetup-testing-lxc']' returned non-zero exit status 1