Code review comment for lp:~bac/launchpad/repeats

Revision history for this message
Robert Collins (lifeless) wrote :

testr assumes that test ids are unique: we already have a hard
dependency on uniqueness, and I had totally forgotten about our test
suite containing duplicates.
https://launchpad.net/bugs/682771
and
https://launchpad.net/bugs/682772

were filed when I originally noticed that we had duplicates.

This branch would result in all tests with an identical name being
loaded when its given, but testr will already be assuming that there
is only one such test, so test counts will be permanently off.

It would be simpler, and better, to fix the root of the issue.
Testtools has a feature for renaming the test id of a test, if we have
multiple parameterised versions of a single test (testscenarios uses
that to do its parameterisation).

-Rob

« Back to merge proposal