Launchpad itself

Code review comment for lp:~bac/launchpad/bug-759467

  1. bug-759467
  2. Merge into devel
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the review Graham.

[1] Like most of the interesting parts of this branch, the enumcol extension was all from Robert.

[2] I added DB_INCOMPLETE_BUGTASK_STATUSES but did not include INCOMPLETE. In the case you site, new_status can never be INCOMPLETE as it would've been previously mapped to one of these two.

[3] Done.

[4] The store.flush() was removed.

[5] Much nicer, thanks.

[6] Ditto.

« Back to merge proposal