Nice change. The only note I had for the code was that instead of saying
if not person.is_team: enabled = True else: enabled = False
...(..., enabled=enabled)
it would probably be clearer to say
owner_is_individual = (not person.is_team) ...(..., enabled=owner_is_individual)
I'm not entirely sure the underlining of that section of the story test should be "=" as opposed to "-," but since I don't like rest-style headings at all I'm probably talking nonsense.
Anyway: Approved, and keep 'em coming. :-)
Jeroen
« Back to merge proposal
Nice change. The only note I had for the code was that instead of saying
if not person.is_team:
enabled = True
else:
enabled = False
...(..., enabled=enabled)
it would probably be clearer to say
owner_is_individual = (not person.is_team) owner_is_ individual)
...(..., enabled=
I'm not entirely sure the underlining of that section of the story test should be "=" as opposed to "-," but since I don't like rest-style headings at all I'm probably talking nonsense.
Anyway: Approved, and keep 'em coming. :-)
Jeroen