Merge lp:~bac/launchpad/bug-561586 into lp:launchpad

[Brad Crittenden]

Move registry javascript to lp/registry/javascript.

= Summary =

Move registry javascript to (surprise!) lp/registry/javascript.

== Proposed fix ==

Make the move and then fix up all of the paths.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

bin/test -vvm lp.registry -t test_yuitests

== Demo and Q/A ==

Check out milestone and timelines and ensure the JS isn't broken.

= Launchpad lint =

Hmmm, I'm certainly not responsible for any of these lint issues but
will have a look at the ones that seem reasonable.

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/javascript/tests/timeline.js
  utilities/lp-deps.py
  lib/lp/registry/javascript/tests/test_milestone_table.html
  lib/lp/registry/windmill/tests/test_yuitests.py
  lib/lp/registry/javascript/tests/timeline-iframe.html
  lib/lp/registry/javascript/tests/test_milestone_table.js

== JSLint notices ==
No handlers could be found for logger "bzr"
jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/canonical/launchpad/icing/PlotKit_Packed.js':
Line 16 character 11: Parens are not needed here.
if(typeof (MochiKit.Base)=="undefined"||typeof
(MochiKit.DOM)=="undefined"||typeof
(MochiKit.Color)=="undefined"||typeof (MochiKit.Format)=="undefined"){

Line 16 character 48: Parens are not needed here.
if(typeof (MochiKit.Base)=="undefined"||typeof
(MochiKit.DOM)=="undefined"||typeof
(MochiKit.Color)=="undefined"||typeof (MochiKit.Format)=="undefined"){

Line 16 character 84: Parens are not needed here.
if(typeof (MochiKit.Base)=="undefined"||typeof
(MochiKit.DOM)=="undefined"||typeof
(MochiKit.Color)=="undefined"||typeof (MochiKit.Format)=="undefined"){

Line 16 character 122: Parens are not needed here.
if(typeof (MochiKit.Base)=="undefined"||typeof
(MochiKit.DOM)=="undefined"||typeof
(MochiKit.Color)=="undefined"||typeof (MochiKit.Format)=="undefined"){

Line 41 character 11: Parens are not needed here.
if(typeof (PlotKit.Base)=="undefined"){

Line 54 character 16: Parens are not needed here.
return (typeof (Object.extend)=="function");

Line 66 character 12: Use the array literal notation [].
var _8=new Array();

Line 79 character 12: Use the array literal notation [].
return new Array();

Line 81 character 13: Use the array literal notation [].
var _11=new Array();

Line 85 character 25: Use '!==' to compare with '0'.
if(m.compare(_10[i],_12)!=0){

Line 110 character 13: Use the array literal notation [].
var _26=new Array();

Line 167 character 11: Parens are not needed here.
if(typeof (lst[x])=="function"){

Line 166 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var x in lst){

Line 181 character 11: Parens are not needed here.
if(typeof (lst[x])=="function"){

Line 180 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var x in lst){

Line 195 character 11: Parens are not needed here.
if(typeof (lst[x])=="function"){

Line 194 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var x in lst){

Line 249 character 11: Parens are not needed here.
if(typeof (PlotKit.Base)=="undefined"){

Line 253 character 7: 'e' is already defined.
catch(e){

Line 256 character 11: Parens are not needed here.
if(typeof (PlotKit.Layout)=="undefined"){

Line 290 character 15: Use the array literal notation [].
this.bars=new Array();

Line 291 character 17: Use the array literal notation [].
this.points=new Array();

Line 292 character 17: Use the array literal notation [].
this.slices=new Array();

Line 293 character 17: Use the array literal notation [].
this.xticks=new Array();

Line 294 character 17: Use the array literal notation [].
this.yticks=new Array();

Line 295 character 19: Use the array literal notation [].
this.datasets=new Array();

Line 321 character 13: Use the array literal notation [].
var _57=new Array();

Line 322 character 13: Use the array literal notation [].
var _58=new Array();

Line 371 character 28: Use '===' to compare with 'null'.
if(this.hitTestCache.x2maxy==null){

Line 378 character 10: 'i' is already defined.
for(var i=1;i<_63.length;i++){

Line 385 character 8: Use '!==' to compare with 'null'.
if((_64!=null)){

Line 403 character 10: 'i' is already defined.
for(var i=0;i<this.slices.length;i++){

Line 457 character 15: Use '===' to compare with '0'.
if(this.xrange==0){

Line 463 character 15: Use '===' to compare with '0'.
if(this.yrange==0){

Line 512 character 15: Use the array literal notation [].
this.bars=new Array();

Line 513 character 6: 'i' is already defined.
var i=0;

Line 514 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var _95 in this.datasets){

Line 554 character 15: Use the array literal notation [].
this.bars=new Array();

Line 555 character 6: 'i' is already defined.
var i=0;

Line 556 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var _107 in this.datasets){

Line 580 character 17: Use the array literal notation [].
this.points=new Array();

Line 589 character 2: Be careful when making functions within a loop.
Consider putting the function in a closure.
});

Line 582 character 1: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
for(var _113 in this.datasets){

Line 613 character 17: Use the array literal notation [].
this.slices=new Array();

Line 620 character 14: Use '!==' to compare with '0'.
if(_122[i][1]!=0){

Line 629 character 17: Use the array literal notation [].
this.xticks=new Array();

Line 646 character 17: Use the array literal notation [].
this.xticks=new Array();

Line 666 character 17: Use the array literal notation [].
this.yticks=new Array();

Line 680 character 17: Use the array literal notation [].
this.yticks=new Array();

Line 718 character 17: Use the array literal notation [].
this.xticks=new Array();

Line 718 character 17: Too many errors. (32% scanned).

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/Base.js':
Line 21 character 15: Parens are not needed here.
    if (typeof(MochiKit.Base) == 'undefined' ||

Line 22 character 15: Parens are not needed here.
        typeof(MochiKit.DOM) == 'undefined' ||

Line 23 character 15: Parens are not needed here.
        typeof(MochiKit.Color) == 'undefined' ||

Line 24 character 15: Parens are not needed here.
        typeof(MochiKit.Format) == 'undefined')

Line 30 character 62: Missing semicolon.
    throw "PlotKit depends on MochiKit.{Base,Color,DOM,Format}"

Line 68 character 2: Missing semicolon.
}

Line 74 character 11: Parens are not needed here.
if (typeof(PlotKit.Base) == 'undefined') {

Line 87 character 2: Missing semicolon.
}

Line 93 character 23: Parens are not needed here.
        return (typeof(Object.extend) == 'function');

Line 98 character 2: Missing semicolon.
}

Line 111 character 30: Use the array literal notation [].
        var biggerList = new Array();

Line 128 character 66: Line breaking error ')'.
        if (!m.isArrayLike(sortedList) || (sortedList.length < 1))

Line 129 character 13: Expected '{' and instead saw 'return'.
            return new Array();

Line 129 character 24: Use the array literal notation [].
            return new Array();

Line 131 character 24: Use the array literal notation [].
        var uniq = new Array();

Line 135 character 52: Use '!==' to compare with '0'.
            if (m.compare(sortedList[i], lastElem) != 0) {

Line 145 character 27: Line breaking error 'Color'.
        var mc = MochiKit.Color

Line 145 character 32: Missing semicolon.
        var mc = MochiKit.Color

Line 149 character 46: Missing semicolon.
            return mc.Color[name + "Color"]()

Line 180 character 29: Use the array literal notation [].
        var fractions = new Array();

Line 181 character 29: Line breaking error ')'.
        if (isNil(increment))

Line 182 character 13: Expected '{' and instead saw 'increment'.
            increment = 0.1;

Line 183 character 27: Line breaking error ')'.
        if (isNil(toLevel))

Line 184 character 13: Expected '{' and instead saw 'toLevel'.
            toLevel = 0.4;

Line 185 character 29: Line breaking error ')'.
        if (isNil(fromLevel))

Line 186 character 13: Expected '{' and instead saw 'fromLevel'.
            fromLevel = -0.2;

Line 214 character 36: Line breaking error 'offsetLeft'.
                    curleft += obj.offsetLeft

Line 214 character 46: Missing semicolon.
                    curleft += obj.offsetLeft

Line 218 character 23: Line breaking error ')'.
        else if (obj.x)

Line 219 character 13: Expected '{' and instead saw 'curleft'.
            curleft += obj.x;

Line 227 character 30: Line breaking error 'offsetTop'.
               curtop += obj.offsetTop

Line 227 character 39: Missing semicolon.
               curtop += obj.offsetTop

Line 231 character 22: Line breaking error ')'.
       else if (obj.y)

Line 232 character 12: Expected '{' and instead saw 'curtop'.
           curtop += obj.y;

Line 249 character 23: Parens are not needed here.
            if (typeof(lst[x]) == 'function') continue;

Line 249 character 47: Expected '{' and instead saw 'continue'.
            if (typeof(lst[x]) == 'function') continue;

Line 248 character 9: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
        for (var x in lst) {

Line 263 character 24: Parens are not needed here.
             if (typeof(lst[x]) == 'function') continue;

Line 263 character 48: Expected '{' and instead saw 'continue'.
             if (typeof(lst[x]) == 'function') continue;

Line 262 character 10: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
         for (var x in lst) {

Line 277 character 24: Parens are not needed here.
             if (typeof(lst[x]) == 'function') continue;

Line 277 character 48: Expected '{' and instead saw 'continue'.
             if (typeof(lst[x]) == 'function') continue;

Line 276 character 10: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
         for (var x in lst) {

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/Canvas.js':
Line 26 character 16: Parens are not needed here.
    if ((typeof(PlotKit.Base) == 'undefined') ||

Line 27 character 16: Parens are not needed here.
        (typeof(PlotKit.Layout) == 'undefined'))

Line 33 character 95: Missing semicolon.
    throw "PlotKit.Layout depends on MochiKit.{Base,Color,DOM,Format}
and PlotKit.{Base,Layout}"

Line 41 character 11: Parens are not needed here.
if (typeof(PlotKit.CanvasRenderer) == 'undefined') {

Line 54 character 2: Missing semicolon.
}

Line 57 character 30: Line breaking error ')'.
    if (arguments.length > 0)

Line 58 character 9: Expected '{' and instead saw 'this'.
        this.__init__(element, layout, options);

Line 110 character 28: Line breaking error ')'.
    if (isNil(this.element))

Line 111 character 9: Expected '{' and instead saw 'throw'.
        throw "CanvasRenderer() - passed canvas is not found";

Line 113 character 24: Parens are not needed here.
    if (!this.isIE && !(PlotKit.CanvasRenderer.isSupported(this.element)))

Line 113 character 74: Line breaking error ')'.
    if (!this.isIE && !(PlotKit.CanvasRenderer.isSupported(this.element)))

Line 114 character 9: Expected '{' and instead saw 'throw'.
        throw "CanvasRenderer() - Canvas is not supported.";

Line 116 character 82: Line breaking error ')'.
    if (isNil(this.container) || (this.container.nodeName.toLowerCase()
!= "div"))

Line 117 character 9: Expected '{' and instead saw 'throw'.
        throw "CanvasRenderer() - <canvas> needs to be enclosed in <div>";

Line 120 character 24: Use the array literal notation [].
    this.xlabels = new Array();

Line 121 character 24: Use the array literal notation [].
    this.ylabels = new Array();

Line 168 character 36: Line breaking error ')'.
    if (this.options.drawBackground)

Line 169 character 9: Expected '{' and instead saw 'this'.
        this._renderBackground();

Line 197 character 37: Line breaking error ')'.
        if (this.options.strokeColor)

Line 198 character 13: Expected '{' and instead saw 'context'.
            context.strokeStyle = this.options.strokeColor.toRGBString();

Line 199 character 51: Line breaking error ')'.
        else if (this.options.strokeColorTransform)

Line 200 character 13: Expected '{' and instead saw 'context'.
            context.strokeStyle =
color[this.options.strokeColorTransform]().toRGBString();

Line 204 character 36: Line breaking error ')'.
            if (obj.name == setName)

Line 205 character 17: Expected '{' and instead saw 'plotFunc'.
                plotFunc(context, obj);

Line 206 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 221 character 31: Line breaking error ')'.
        if ((w < 1) || (h < 1))

Line 222 character 13: Expected '{' and instead saw 'return'.
            return;

Line 223 character 36: Line breaking error ')'.
        if (this.options.shouldFill)

Line 224 character 13: Expected '{' and instead saw 'context'.
            context.fillRect(x, y, w, h);

Line 225 character 38: Line breaking error ')'.
        if (this.options.shouldStroke)

Line 226 character 13: Expected '{' and instead saw 'context'.
            context.strokeRect(x, y, w, h);

Line 248 character 37: Line breaking error ')'.
        if (this.options.strokeColor)

Line 249 character 13: Expected '{' and instead saw 'context'.
            context.strokeStyle = this.options.strokeColor.toRGBString();

Line 250 character 51: Line breaking error ')'.
        else if (this.options.strokeColorTransform)

Line 251 character 13: Expected '{' and instead saw 'context'.
            context.strokeStyle = color[strokeX]().toRGBString();

Line 260 character 42: Line breaking error ')'.
                if (point.name == setName)

Line 261 character 21: Expected '{' and instead saw 'ctx_'.
                    ctx_.lineTo(this.area.w * point.x + this.area.x,

Line 269 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 295 character 19: Missing radix parameter.
        centerx = parseInt(centerx);

Line 296 character 19: Missing radix parameter.
        centery = parseInt(centery);

Line 297 character 18: Missing radix parameter.
        radius = parseInt(radius);

Line 318 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 329 character 45: Line breaking error ')'.
                if (this.options.strokeColor)

Line 330 character 21: Expected '{' and instead saw 'context'.
                    context.strokeStyle =
this.options.strokeColor.toRGBString();

Line 331 character 59: Line breaking error ')'.
                else if (this.options.strokeColorTransform)

Line 332 character 21: Expected '{' and instead saw 'context'.
                    context.strokeStyle =
color[this.options.strokeColorTransform]().toRGBString();

Line 342 character 2: Missing semicolon.
}

Line 350 character 59: Line breaking error ')'.
    if (!this.options.drawXAxis && !this.options.drawYAxis)

Line 351 character 9: Expected '{' and instead saw 'return'.
        return;

Line 374 character 49: Expected '{' and instead saw 'return'.
                if (typeof(tick) == "function") return;

Line 374 character 49: Too many errors. (54% scanned).

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/EasyPlot.js':
Line 16 character 15: Parens are not needed here.
    if (typeof(PlotKit.CanvasRenderer) == 'undefined')

Line 18 character 15: Missing semicolon.
        throw ""

Line 29 character 11: Parens are not needed here.
if (typeof(PlotKit.EasyPlot) == 'undefined') {

Line 42 character 2: Missing semicolon.
}

Line 51 character 18: Missing radix parameter.
    this.width = parseInt(divElem.getAttribute('width'));

Line 52 character 19: Missing radix parameter.
    this.height = parseInt(divElem.getAttribute('height'));

Line 67 character 23: Parens are not needed here.
            if (typeof(datasources[i]) == "string") {

Line 101 character 29: Use '===' to compare with '0'.
    if ((this.deferredCount == 0) &&
(PlotKit.Base.keys(this.layout.datasets).length > 0)) {

Line 112 character 21: Use the array literal notation [].
    var table = new Array();

Line 124 character 29: Use '===' to compare with '0'.
    if ((this.deferredCount == 0) &&
(PlotKit.Base.keys(this.layout.datasets).length > 0)) {

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/Layout.js':
Line 18 character 15: Parens are not needed here.
    if (typeof(PlotKit.Base) == 'undefined')

Line 20 character 15: Missing semicolon.
        throw ""

Line 24 character 86: Missing semicolon.
    throw "PlotKit.Layout depends on MochiKit.{Base,Color,DOM,Format}
and PlotKit.Base"

Line 31 character 11: Parens are not needed here.
if (typeof(PlotKit.Layout) == 'undefined') {

Line 44 character 2: Missing semicolon.
}

Line 98 character 21: Use the array literal notation [].
    this.bars = new Array(); // array of bars to plot for bar charts

Line 99 character 23: Use the array literal notation [].
    this.points = new Array(); // array of points to plot for line plots

Line 100 character 23: Use the array literal notation [].
    this.slices = new Array(); // array of slices to draw for pie charts

Line 102 character 23: Use the array literal notation [].
    this.xticks = new Array();

Line 103 character 23: Use the array literal notation [].
    this.yticks = new Array();

Line 106 character 25: Use the array literal notation [].
    this.datasets = new Array();

Line 133 character 20: Line breaking error ')'.
 if (isNil(xcol))

Line 134 character 9: Expected '{' and instead saw 'xcol'.
  xcol = 0;

Line 135 character 20: Line breaking error ')'.
 if (isNil(ycol))

Line 136 character 9: Expected '{' and instead saw 'ycol'.
  ycol = 1;

Line 137 character 20: Line breaking error ')'.
 if (isNil(lcol))

Line 138 character 9: Expected '{' and instead saw 'lcol'.
     lcol = -1;

Line 141 character 20: Use the array literal notation [].
    var data = new Array();

Line 142 character 22: Use the array literal notation [].
    var labels = new Array();

Line 201 character 52: Line breaking error ')'.
            if ((x >= bar.x) && (x <= bar.x + bar.w)

Line 202 character 56: Line breaking error ')'.
                && (y >= bar.y) && (y - bar.y <= bar.h))

Line 203 character 17: Expected '{' and instead saw 'return'.
                return bar;

Line 208 character 38: Use '===' to compare with 'null'.
        if (this.hitTestCache.x2maxy == null) {

Line 218 character 20: 'i' is already defined.
        for (var i = 1; i < xvalues.length; i++) {

Line 226 character 22: Use '!==' to compare with 'null'.
        if ((xbefore != null)) {

Line 248 character 42: Line breaking error ')'.
        if (dist > this.options.pieRadius)

Line 249 character 13: Expected '{' and instead saw 'return'.
            return null;

Line 254 character 20: 'i' is already defined.
        for (var i = 0; i < this.slices.length; i++) {

Line 256 character 68: Line breaking error ')'.
            if (slice.startAngle < angle && slice.endAngle >= angle)

Line 257 character 17: Expected '{' and instead saw 'return'.
                return slice;

Line 291 character 39: Line breaking error ')'.
        if (this.options.xOriginIsZero)

Line 292 character 13: Expected '{' and instead saw 'this'.
            this.minxval = 0;

Line 294 character 13: Expected '{' and instead saw 'this'.
            this.minxval = listMin(map(parseFloat, map(itemgetter(0),
all)));

Line 305 character 39: Line breaking error ')'.
        if (this.options.yOriginIsZero)

Line 306 character 13: Expected '{' and instead saw 'this'.
            this.minyval = 0;

Line 308 character 13: Expected '{' and instead saw 'this'.
            this.minyval = listMin(map(parseFloat, map(itemgetter(1),
all)));

Line 324 character 21: Use '===' to compare with '0'.
    if (this.xrange == 0)

Line 324 character 25: Line breaking error ')'.
    if (this.xrange == 0)

Line 325 character 9: Expected '{' and instead saw 'this'.
        this.xscale = 1.0;

Line 327 character 9: Expected '{' and instead saw 'this'.
        this.xscale = 1/this.xrange;

Line 330 character 21: Use '===' to compare with '0'.
    if (this.yrange == 0)

Line 330 character 25: Line breaking error ')'.
    if (this.yrange == 0)

Line 331 character 9: Expected '{' and instead saw 'this'.
        this.yscale = 1.0;

Line 333 character 9: Expected '{' and instead saw 'this'.
        this.yscale = 1/this.yrange;

Line 392 character 21: Use the array literal notation [].
    this.bars = new Array();

Line 393 character 11: 'i' is already defined.
    var i = 0;

Line 396 character 47: Expected '{' and instead saw 'continue'.
        if (PlotKit.Base.isFuncLike(dataset)) continue;

Line 394 character 5: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
    for (var setName in this.datasets) {

Line 455 character 21: Use the array literal notation [].
    this.bars = new Array();

Line 456 character 11: 'i' is already defined.
    var i = 0;

Line 456 character 11: Too many errors. (59% scanned).

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/PlotKit.js':
Line 18 character 11: Parens are not needed here.
if (typeof(PlotKit.PlotKit) == 'undefined') {

Line 68 character 13: The body of a for in should be wrapped in an if
statement to filter unwanted properties from the prototype.
            for (k in m.EXPORT_TAGS) {

Line 87 character 15: Parens are not needed here.
    if (typeof(PlotKit.__compat__) == 'undefined') {

Line 118 character 20: 'i' is already defined.
        for (var i = 0; i < modules.length; i++) {

Line 147 character 17: document.write can be a form of eval.
                document.write('<script src="' + uri +

Line 150 character 10: Unnecessary semicolon.
        };

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/SVG.js':
Line 24 character 15: Parens are not needed here.
    if (typeof(PlotKit.Layout) == 'undefined')

Line 30 character 81: Missing semicolon.
    throw "PlotKit depends on MochiKit.{Base,Color,DOM,Format} and
PlotKit.Layout"

Line 39 character 29: Line breaking error ')'.
    if (arguments.length > 0)

Line 40 character 9: Expected '{' and instead saw 'this'.
        this.__init__(element, layout, options);

Line 52 character 2: Missing semicolon.
}

Line 88 character 19: Missing radix parameter.
    this.height = parseInt(this.element.getAttribute("height"));

Line 89 character 18: Missing radix parameter.
    this.width = parseInt(this.element.getAttribute("width"));

Line 104 character 28: Line breaking error ')'.
    if (isNil(this.element))

Line 105 character 9: Expected '{' and instead saw 'throw'.
        throw "SVGRenderer() - passed SVG object is not found";

Line 107 character 80: Line breaking error ')'.
    if (isNil(this.container) || this.container.nodeName.toLowerCase()
!= "div")

Line 108 character 9: Expected '{' and instead saw 'throw'.
        throw "SVGRenderer() - No DIV's around the SVG.";

Line 111 character 24: Use the array literal notation [].
    this.xlabels = new Array();

Line 112 character 24: Use the array literal notation [].
    this.ylabels = new Array();

Line 132 character 36: Line breaking error ')'.
    if (this.options.drawBackground)

Line 133 character 9: Expected '{' and instead saw 'this'.
        this._renderBackground();

Line 158 character 25: Use the array literal notation [].
        var attrs = new Array();

Line 161 character 36: Line breaking error ')'.
        if (this.options.shouldFill)

Line 162 character 13: Expected '{' and instead saw 'attrs'.
            attrs["fill"] = color.toRGBString();

Line 162 character 19: ['fill'] is better written in dot notation.
            attrs["fill"] = color.toRGBString();

Line 164 character 13: Expected '{' and instead saw 'attrs'.
            attrs["fill"] = "none";

Line 164 character 19: ['fill'] is better written in dot notation.
            attrs["fill"] = "none";

Line 168 character 41: Line breaking error ')'.
            if (this.options.strokeColor)

Line 169 character 17: Expected '{' and instead saw 'attrs'.
                attrs["stroke"] = this.options.strokeColor.toRGBString();

Line 169 character 23: ['stroke'] is better written in dot notation.
                attrs["stroke"] = this.options.strokeColor.toRGBString();

Line 170 character 55: Line breaking error ')'.
            else if (this.options.strokeColorTransform)

Line 171 character 17: Expected '{' and instead saw 'attrs'.
                attrs["stroke"] =
color[this.options.strokeColorTransform]().toRGBString();

Line 171 character 23: ['stroke'] is better written in dot notation.
                attrs["stroke"] =
color[this.options.strokeColorTransform]().toRGBString();

Line 172 character 19: ['strokeWidth'] is better written in dot notation.
            attrs["strokeWidth"] = this.options.strokeWidth;

Line 175 character 22: Line breaking error ')'.
        if (startFunc)

Line 176 character 13: Expected '{' and instead saw 'startFunc'.
            startFunc(attrs);

Line 179 character 36: Line breaking error ')'.
            if (obj.name == setName)

Line 180 character 17: Expected '{' and instead saw 'plotFunc'.
                plotFunc(attrs, obj);

Line 181 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 184 character 20: Line breaking error ')'.
        if (endFunc)

Line 185 character 13: Expected '{' and instead saw 'endFunc'.
            endFunc(attrs);

Line 212 character 35: Parens are not needed here.
        this._tempPointsBuffer += (this.area.x) + "," +
(this.area.y+this.area.h) + " ";

Line 217 character 15: ['points'] is better written in dot notation.
        attrs["points"] = this._tempPointsBuffer;

Line 245 character 36: Line breaking error ')'.
        if (this.options.shouldFill)

Line 246 character 13: Expected '{' and instead saw 'attrs'.
            attrs["fill"] = color.toRGBString();

Line 246 character 19: ['fill'] is better written in dot notation.
            attrs["fill"] = color.toRGBString();

Line 248 character 13: Expected '{' and instead saw 'attrs'.
            attrs["fill"] = "none";

Line 248 character 19: ['fill'] is better written in dot notation.
            attrs["fill"] = "none";

Line 252 character 41: Line breaking error ')'.
            if (this.options.strokeColor)

Line 253 character 17: Expected '{' and instead saw 'attrs'.
                attrs["stroke"] = this.options.strokeColor.toRGBString();

Line 253 character 23: ['stroke'] is better written in dot notation.
                attrs["stroke"] = this.options.strokeColor.toRGBString();

Line 254 character 55: Line breaking error ')'.
            else if (this.options.strokeColorTransform)

Line 255 character 17: Expected '{' and instead saw 'attrs'.
                attrs["stroke"] =
color[this.options.strokeColorTransform]().toRGBString();

Line 255 character 23: ['stroke'] is better written in dot notation.
                attrs["stroke"] =
color[this.options.strokeColorTransform]().toRGBString();

Line 256 character 19: ['style'] is better written in dot notation.
            attrs["style"] = "stroke-width: " + this.options.strokeWidth;

Line 264 character 19: 'attrs' is already defined.
        var attrs = new Array();

Line 264 character 19: Too many errors. (37% scanned).

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/SweetCanvas.js':
Line 18 character 15: Parens are not needed here.
    if (typeof(PlotKit.CanvasRenderer) == 'undefined')

Line 24 character 95: Missing semicolon.
    throw "SweetCanvas depends on MochiKit.{Base,Color,DOM,Format} and
PlotKit.{Layout, Canvas}"

Line 28 character 11: Parens are not needed here.
if (typeof(PlotKit.SweetCanvasRenderer) == 'undefined') {

Line 89 character 36: Line breaking error ')'.
            if (name == setNames[i])

Line 90 character 17: Expected '{' and instead saw 'return'.
                return colorScheme[i%colorCount];

Line 101 character 31: Line breaking error ')'.
        if ((w < 1) || (h < 1))

Line 102 character 13: Expected '{' and instead saw 'return'.
            return;

Line 160 character 38: Line breaking error ')'.
            if (point.name == setName)

Line 161 character 17: Expected '{' and instead saw 'ctx_'.
                ctx_.lineTo(this.area.w * point.x + this.area.x,

Line 169 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 218 character 19: Missing radix parameter.
        centerx = parseInt(centerx);

Line 219 character 19: Missing radix parameter.
        centery = parseInt(centery);

Line 220 character 18: Missing radix parameter.
        radius = parseInt(radius);

Line 257 character 10: Be careful when making functions within a loop.
Consider putting the function in a closure.
        };

Line 325 character 25: Missing semicolon.
PlotKit.SweetCanvas = {}

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/SweetSVG.js':
Line 19 character 15: Parens are not needed here.
    if (typeof(PlotKit.SVGRenderer) == 'undefined')

Line 25 character 89: Missing semicolon.
    throw "SweetSVG depends on MochiKit.{Base,Color,DOM,Format} and
PlotKit.{Layout, SVG}"

Line 29 character 11: Parens are not needed here.
if (typeof(PlotKit.SweetSVGRenderer) == 'undefined') {

Line 106 character 31: Line breaking error ')'.
        if ((w < 1) || (h < 1))

Line 107 character 13: Expected '{' and instead saw 'return'.
            return;

Line 110 character 15: ['style'] is better written in dot notation.
        attrs["style"] = strokeStyle;

Line 131 character 35: Parens are not needed here.
        this._tempPointsBuffer += (this.area.x) + "," +
(this.area.y+this.area.h) + " ";

Line 136 character 15: ['points'] is better written in dot notation.
        attrs["points"] = this._tempPointsBuffer;

Line 138 character 15: ['stroke'] is better written in dot notation.
        attrs["stroke"] = "none";

Line 139 character 15: ['transform'] is better written in dot notation.
        attrs["transform"] = "translate(-2, -1)";

Line 140 character 15: ['style'] is better written in dot notation.
        attrs["style"] = shadowStyle;

Line 144 character 15: ['transform'] is better written in dot notation.
        attrs["transform"] = "";

Line 145 character 15: ['style'] is better written in dot notation.
        attrs["style"] = strokeStyle;

Line 225 character 22: Missing semicolon.
PlotKit.SweetSVG = {}

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/PlotKit/excanvas.js':
Line 49 character 29: ['g_vml_'] is better written in dot notation.
        if (!doc.namespaces["g_vml_"]) {

Line 106 character 29: Missing semicolon.
        return this.context_ = new CanvasRenderingContext2D_(this);

Line 106 character 30: Expected an identifier and instead saw '='.
        return this.context_ = new CanvasRenderingContext2D_(this);

Line 106 character 30: Stopping, unable to continue. (14% scanned).

jslint: Lint found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/contrib/slimmer/tests/moo.ajax.js':
Line 21 character 50: Expected '{' and instead saw 'this'.
   if (this.transport.overrideMimeType)
this.transport.setRequestHeader('Connection', 'close');

Line 28 character 32: Line breaking error ')'.
   if (this.onComplete)

Line 29 character 17: Expected '{' and instead saw 'setTimeout'.
    setTimeout(function(){this.onComplete(this.transport);}.bind(this), 10);

Line 30 character 28: Line breaking error ')'.
   if (this.update)

Line 31 character 17: Expected '{' and instead saw 'setTimeout'.
    setTimeout(function(){this.update.innerHTML =
this.transport.responseText;}.bind(this), 10);

Line 37 character 35: Expected '{' and instead saw 'return'.
  if (window.ActiveXObject) return new ActiveXObject('Microsoft.XMLHTTP');

Line 38 character 41: Expected '{' and instead saw 'return'.
  else if (window.XMLHttpRequest) return new XMLHttpRequest();

Line 39 character 14: Expected '{' and instead saw 'return'.
  else return false;

jslint: No problem found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/lp/registry/javascript/tests/test_milestone_table.js'.

jslint: No problem found in
'/home/bac/launchpad/lp-branches/bug-561586/lib/lp/registry/javascript/tests/timeline.js'.

jslint: 13 files to lint.

== Pyflakes notices ==

utilities/lp-deps.py
    15: 'sys' imported but unused

== Pylint notices ==

utilities/lp-deps.py
    15: [W0611] Unused import sys

[Brad Crittenden (bac)]

Edwin based on your suggestion on IRC I have also updated the registry javascript to be 'lp.registry'. I also fixed one lint issue and a problem with the code test not looking for lp.js in the right place.

Incremental at http://pastebin.ubuntu.com/424191/

[Edwin Grubbs (edwin-grubbs)]

Hi Brad,

Thanks for making the tedious changes so I won't get stuck doing it.

merge-approved

-Edwin

review: Approve

=== modified file 'lib/lp/code/javascript/tests/test_productseries-setbranch.html'
--- lib/lp/code/javascript/tests/test_productseries-setbranch.html	2010-04-05 18:58:07 +0000
+++ lib/lp/code/javascript/tests/test_productseries-setbranch.html	2010-05-06 18:27:28 +0000
@@ -11,7 +11,7 @@
   <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssfonts/fonts.css"/>
   <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssbase/base.css"/>
   <link rel="stylesheet" href="../../../../canonical/launchpad/javascript/test.css" />
-  <script type="text/javascript" src="../../../../canonical/launchpad/lp/lp.js"></script>
+  <script type="text/javascript" src="../../../../canonical/launchpad/javascript/lp/lp.js"></script>
 
   <!-- The module under test -->
   <script type="text/javascript" src="../productseries-setbranch.js"></script>
 
=== modified file 'lib/lp/registry/browser/__init__.py'
--- lib/lp/registry/browser/__init__.py	2010-02-09 05:13:05 +0000
+++ lib/lp/registry/browser/__init__.py	2010-05-06 18:27:28 +0000
@@ -101,7 +101,8 @@
             }
         return """
             YUI().use(
-                'node', 'registry.milestoneoverlay', 'registry.milestonetable',
+                'node', 'lp.registry.milestoneoverlay',
+                'lp.registry.milestonetable',
                 function (Y) {
 
                 var series_uri = '%(series_api_uri)s';
@@ -116,15 +117,15 @@
                     var config = {
                         milestone_form_uri: milestone_form_uri,
                         series_uri: series_uri,
-                        next_step: Y.registry.milestonetable.get_milestone_row,
+                        next_step: Y.lp.registry.milestonetable.get_milestone_row,
                         activate_node: create_milestone_link
                         };
-                    Y.registry.milestoneoverlay.attach_widget(config);
+                    Y.lp.registry.milestoneoverlay.attach_widget(config);
                     var table_config = {
                         milestone_row_uri_template: milestone_row_uri,
                         milestone_rows_id: milestone_rows_id
                         }
-                    Y.registry.milestonetable.setup(table_config);
+                    Y.lp.registry.milestonetable.setup(table_config);
                 });
             });
             """ % uris
 
=== modified file 'lib/lp/registry/browser/tests/productrelease-views.txt'
--- lib/lp/registry/browser/tests/productrelease-views.txt	2010-02-09 05:13:05 +0000
+++ lib/lp/registry/browser/tests/productrelease-views.txt	2010-05-06 18:27:28 +0000
@@ -124,7 +124,7 @@
     >>> script = find_tag_by_id(view.render(), 'milestone-script')
     >>> print script
     <script id="milestone-script" type="text/javascript">
-        LPS.use(... 'registry.milestoneoverlay'...
+        LPS.use(... 'lp.registry.milestoneoverlay'...
             var milestone_form_uri = '.../app/simple/+addmilestone/++form++';
             var series_uri = '/app/simple';
             ...
 
=== modified file 'lib/lp/registry/browser/tests/productseries-views.txt'
--- lib/lp/registry/browser/tests/productseries-views.txt	2010-05-03 18:28:16 +0000
+++ lib/lp/registry/browser/tests/productseries-views.txt	2010-05-06 18:27:28 +0000
@@ -80,7 +80,7 @@
     >>> script = find_tag_by_id(view.render(), 'milestone-script')
     >>> print script
     <script id="milestone-script" type="text/javascript">
-        YUI().use(... 'registry.milestoneoverlay', 'registry.milestonetable'...
+        YUI().use(... 'lp.registry.milestoneoverlay', 'lp.registry.milestonetable'...
             var series_uri = '/app/simple';
             var milestone_form_uri = '.../app/simple/+addmilestone/++form++';
             var milestone_row_uri =
@@ -90,8 +90,8 @@
                 var create_milestone_link = Y.get(
                     '.menu-link-create_milestone');
                 create_milestone_link.addClass('js-action');...
-                Y.registry.milestoneoverlay.attach_widget(config);...
-                Y.registry.milestonetable.setup(table_config);...
+                Y.lp.registry.milestoneoverlay.attach_widget(config);...
+                Y.lp.registry.milestonetable.setup(table_config);...
 
 If the Create milestone link is not enabled, the script is not present.
 
 
=== renamed directory 'lib/canonical/launchpad/javascript/registry' => 'lib/lp/registry/javascript'
=== modified file 'lib/lp/registry/javascript/milestoneoverlay.js'
--- lib/canonical/launchpad/javascript/registry/milestoneoverlay.js	2010-02-09 05:13:05 +0000
+++ lib/lp/registry/javascript/milestoneoverlay.js	2010-05-06 18:27:28 +0000
@@ -3,12 +3,12 @@
  *
  * A milestone form overlay that can create a milestone within any page.
  *
- * @module Y.registry.milestoneoverlay
+ * @module Y.lp.registry.milestoneoverlay
  * @requires  dom, node, io-base, lazr.anim, lazr.formoverlay
  */
-YUI.add('registry.milestoneoverlay', function(Y) {
-    Y.log('loading registry.milestoneoverlay');
-    var module = Y.namespace('registry.milestoneoverlay');
+YUI.add('lp.registry.milestoneoverlay', function(Y) {
+    Y.log('loading lp.registry.milestoneoverlay');
+    var module = Y.namespace('lp.registry.milestoneoverlay');
 
     var milestone_form;
     var milestone_form_uri;
 
=== modified file 'lib/lp/registry/javascript/milestonetable.js'
--- lib/canonical/launchpad/javascript/registry/milestonetable.js	2010-02-12 16:29:55 +0000
+++ lib/lp/registry/javascript/milestonetable.js	2010-05-06 18:27:28 +0000
@@ -3,12 +3,12 @@
  *
  * Dynamically add milestones to an HTML table.
  *
- * @module Y.registry.milestonetable
+ * @module Y.lp.registry.milestonetable
  * @requires node, io-base, substitute, lazr.anim
  */
-YUI.add('registry.milestonetable', function(Y) {
-    Y.log('loading registry.milestonetable');
-    var module = Y.namespace('registry.milestonetable');
+YUI.add('lp.registry.milestonetable', function(Y) {
+    Y.log('loading lp.registry.milestonetable');
+    var module = Y.namespace('lp.registry.milestonetable');
 
     // get_milestone_row() needs these when it is called. Other methods
     // should get this information passed as an argument.
@@ -119,4 +119,3 @@
 }, "0.1", {"requires": [
     "node", "io-base", "substitute", "lazr.anim"
     ]});
-
 
=== modified file 'lib/lp/registry/javascript/team.js'
--- lib/canonical/launchpad/javascript/registry/team.js	2010-01-29 10:52:58 +0000
+++ lib/lp/registry/javascript/team.js	2010-05-06 18:27:28 +0000
@@ -5,9 +5,9 @@
  * @module lp.subscriber
  */
 
-YUI.add('registry.team', function(Y) {
+YUI.add('lp.registry.team', function(Y) {
 
-var module = Y.namespace('registry.team');
+var module = Y.namespace('lp.registry.team');
 
 /*
  * Initialize click handler for the add member link
 
=== modified file 'lib/lp/registry/javascript/tests/test_milestone_table.html'
--- lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.html	2010-03-30 18:54:42 +0000
+++ lib/lp/registry/javascript/tests/test_milestone_table.html	2010-05-06 18:27:28 +0000
@@ -4,12 +4,12 @@
   <title>Launchpad milestonetable</title>
 
   <!-- YUI 3.0 Setup -->
-  <script type="text/javascript" src="../../../icing/yui/yui/yui.js"></script>
-  <script type="text/javascript" src="../../../icing/lazr/build/lazr.js"></script>
-  <link rel="stylesheet" href="../../../icing/yui/cssreset/reset.css"/>
-  <link rel="stylesheet" href="../../../icing/yui/cssfonts/fonts.css"/>
-  <link rel="stylesheet" href="../../../icing/yui/cssbase/base.css"/>
-  <link rel="stylesheet" href="../../test.css" />
+  <script type="text/javascript" src="../../../../canonical/launchpad/icing/yui/yui/yui.js"></script>
+  <script type="text/javascript" src="../../../../canonical/launchpad/icing/lazr/build/lazr.js"></script>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssreset/reset.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssfonts/fonts.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssbase/base.css"/>
+  <link rel="stylesheet" href="../../../canonical/launchpad/javascript/test.css" />
 
   <!-- The module under test -->
   <script type="text/javascript" src="../milestonetable.js"></script>
 
=== modified file 'lib/lp/registry/javascript/tests/test_milestone_table.js'
--- lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.js	2010-03-30 18:57:05 +0000
+++ lib/lp/registry/javascript/tests/test_milestone_table.js	2010-05-06 18:27:28 +0000
@@ -1,11 +1,11 @@
-/* Copyright (c) 2009, Canonical Ltd. All rights reserved. */
+/* Copyright (c) 2009-2010, Canonical Ltd. All rights reserved. */
 
 YUI({
-    base: '../../../icing/yui/',
+    base: '../../../../canonical/launchpad/icing/yui/',
     filter: 'raw', combine: false
-    }).use('test', 'console', 'registry.milestonetable', function(Y) {
+    }).use('test', 'console', 'lp.registry.milestonetable', function(Y) {
 
-    var milestonetable = Y.registry.milestonetable;
+    var milestonetable = Y.lp.registry.milestonetable;
     var suite = new Y.Test.Suite("milestonetable Tests");
 
     suite.add(new Y.Test.Case({
 
=== modified file 'lib/lp/registry/javascript/tests/timeline-iframe.html'
--- lib/canonical/launchpad/javascript/registry/tests/timeline-iframe.html	2010-02-11 20:10:01 +0000
+++ lib/lp/registry/javascript/tests/timeline-iframe.html	2010-05-06 18:27:28 +0000
@@ -4,10 +4,10 @@
   <title>Launchpad TimelineGraph Widget</title>
 
   <!-- YUI 3.0 Setup -->
-  <script type="text/javascript" src="../../../icing/yui/yui/yui.js"></script>
-  <link rel="stylesheet" href="../../../icing/yui/cssreset/reset.css"/>
-  <link rel="stylesheet" href="../../../icing/yui/cssfonts/fonts.css"/>
-  <link rel="stylesheet" href="../../../icing/yui/cssbase/base.css"/>
+  <script type="text/javascript" src="../../../../canonical/launchpad/icing/yui/yui/yui.js"></script>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssreset/reset.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssfonts/fonts.css"/>
+  <link rel="stylesheet" href="../../../../canonical/launchpad/icing/yui/cssbase/base.css"/>
 
   <!-- The module under test -->
   <script type="text/javascript" src="../timeline.js"></script>
 
=== modified file 'lib/lp/registry/javascript/tests/timeline.js'
--- lib/canonical/launchpad/javascript/registry/tests/timeline.js	2010-03-31 15:40:42 +0000
+++ lib/lp/registry/javascript/tests/timeline.js	2010-05-06 18:27:28 +0000
@@ -1,10 +1,10 @@
 /* Copyright (c) 2009, Canonical Ltd. All rights reserved. */
 
 YUI({
-    base: '../../../icing/yui/',
+    base: '../../../../canonical/launchpad/icing/yui/',
     filter: 'raw',
     combine: false
-    }).use('test', 'console', 'registry.timeline', function(Y) {
+    }).use('test', 'console', 'lp.registry.timeline', function(Y) {
 
 var Assert = Y.Assert;  // For easy access to isTrue(), etc.
 
@@ -85,7 +85,7 @@
     name: 'minimal-config',
 
     setUp: function() {
-        this.timeline_graph = new Y.registry.timeline.TimelineGraph(
+        this.timeline_graph = new Y.lp.registry.timeline.TimelineGraph(
             MINIMAL_CONFIG);
         this.timeline_graph.render();
         this.content_box = this.timeline_graph.get('contentBox');
@@ -99,7 +99,7 @@
 
     test_canvas_creation: function() {
         Assert.isInstanceOf(
-            Y.registry.timeline.TimelineGraph,
+            Y.lp.registry.timeline.TimelineGraph,
             this.timeline_graph,
             "TimelineGraph was not created.");
 
@@ -150,7 +150,7 @@
     name: 'resizing-config',
 
     setUp: function() {
-        this.timeline_graph = new Y.registry.timeline.TimelineGraph(
+        this.timeline_graph = new Y.lp.registry.timeline.TimelineGraph(
             RESIZING_CONFIG);
         this.timeline_graph.render();
         this.content_box = this.timeline_graph.get('contentBox');
@@ -217,7 +217,7 @@
     name: 'medium-config',
 
     setUp: function() {
-        this.timeline_graph = new Y.registry.timeline.TimelineGraph(
+        this.timeline_graph = new Y.lp.registry.timeline.TimelineGraph(
             MEDIUM_CONFIG);
         this.timeline_graph.render();
         this.content_box = this.timeline_graph.get('contentBox');
 
=== modified file 'lib/lp/registry/javascript/timeline.js'
--- lib/canonical/launchpad/javascript/registry/timeline.js	2009-11-23 19:29:02 +0000
+++ lib/lp/registry/javascript/timeline.js	2010-05-06 18:27:28 +0000
@@ -6,9 +6,9 @@
  * @module timeline
  */
 
-YUI.add('registry.timeline', function(Y) {
+YUI.add('lp.registry.timeline', function(Y) {
 
-var module = Y.namespace('registry.timeline');
+var module = Y.namespace('lp.registry.timeline');
 
 var TIMELINE_GRAPH = 'timelinegraph';
 var OBSOLETE_SERIES_STATUS = 'Obsolete';
 
=== modified file 'lib/lp/registry/templates/object-timeline-graph.pt'
--- lib/lp/registry/templates/object-timeline-graph.pt	2010-02-11 19:49:45 +0000
+++ lib/lp/registry/templates/object-timeline-graph.pt	2010-05-06 18:27:28 +0000
@@ -34,7 +34,7 @@
           include_inactive = false;
       }
 
-      LPS.use('registry.timeline', 'node', 'lp.dragscroll', function(Y) {
+      LPS.use('lp.registry.timeline', 'node', 'lp.dragscroll', function(Y) {
           Y.on('domready', function(e) {
               if (Y.UA.ie) {
                   return;
@@ -59,7 +59,7 @@
                   if (resize_frame !== '') {
                       config.resize_frame = resize_frame;
                   }
-                  var graph = new Y.registry.timeline.TimelineGraph(config);
+                  var graph = new Y.lp.registry.timeline.TimelineGraph(config);
                   graph.render();
                   Y.one('#spinner').setStyle('display', 'none');
                   // Scroll to the most recent milestones or
 
=== modified file 'lib/lp/registry/templates/productrelease-add-from-series.pt'
--- lib/lp/registry/templates/productrelease-add-from-series.pt	2010-02-09 05:13:05 +0000
+++ lib/lp/registry/templates/productrelease-add-from-series.pt	2010-05-06 18:27:28 +0000
@@ -14,7 +14,7 @@
   <tal:script
     replace="structure
     string:&lt;script id='milestone-script' type='text/javascript'&gt;" />
-    LPS.use('node', 'registry.milestoneoverlay', function (Y) {
+    LPS.use('node', 'lp.registry.milestoneoverlay', function (Y) {
 
         // This is a value for the SELECT OPTION which is passed with
         // the SELECT's "change" event. It includes some symbols that are not
@@ -57,7 +57,7 @@
                 activate_node: create_milestone_link
                 };
             if (!Y.UA.ie) {
-                Y.registry.milestoneoverlay.attach_widget(config);
+                Y.lp.registry.milestoneoverlay.attach_widget(config);
             }
         });
     });
 
=== modified file 'lib/lp/registry/templates/team-portlet-membership.pt'
--- lib/lp/registry/templates/team-portlet-membership.pt	2010-04-22 17:18:29 +0000
+++ lib/lp/registry/templates/team-portlet-membership.pt	2010-05-06 18:27:28 +0000
@@ -105,10 +105,10 @@
           tal:condition="link/enabled">
         <script type="text/javascript"
                 tal:content="string:
-          YUI().use('registry.team', function(Y) {
+          YUI().use('lp.registry.team', function(Y) {
               Y.on('load',
                   function(e) {
-                      Y.registry.team.setup_add_member_handler();
+                      Y.lp.registry.team.setup_add_member_handler();
                   },
                   window);
           });
 
=== modified file 'lib/lp/registry/windmill/tests/test_yuitests.py'
--- lib/lp/registry/windmill/tests/test_yuitests.py	2010-03-30 21:49:22 +0000
+++ lib/lp/registry/windmill/tests/test_yuitests.py	2010-05-06 18:27:28 +0000
@@ -17,5 +17,5 @@
 
 
 def test_suite():
-    app_testing_path = 'canonical/launchpad/javascript/registry/tests'
+    app_testing_path = 'lp/registry/javascript/tests'
     return build_yui_unittest_suite(app_testing_path, RegistryYUIUnitTestCase)
 
=== modified file 'utilities/lp-deps.py'
--- utilities/lp-deps.py	2010-04-01 18:16:05 +0000
+++ utilities/lp-deps.py	2010-05-06 18:27:28 +0000
@@ -12,14 +12,16 @@
 __metaclass__ = type
 
 import os
-import sys
+
 
 TOP = os.path.abspath(
     os.path.join(os.path.dirname(__file__), '..'))
 # JS_DIRSET is a tuple of the dir where the code exists, and the name of the
 # symlink it should be linked as in the icing build directory.
 JS_DIRSET = [
-    (os.path.join('lib', 'lp', 'code', 'javascript'), 'code'),]
+    (os.path.join('lib', 'lp', 'code', 'javascript'), 'code'),
+    (os.path.join('lib', 'lp', 'registry', 'javascript'), 'registry'),
+    ]
 ICING_ROOT = os.path.join(TOP, 'lib', 'canonical', 'launchpad', 'icing')
 ICING_BUILD = os.path.join(ICING_ROOT, 'build')