Launchpad itself

Code review comment for lp:~bac/launchpad/bug-419742

bug-419742
Merge into devel

Revision history for this message

Brad Crittenden (bac) wrote on 2009-10-22:

= Summary =

Bug 419742 suggested new information to present on the $product/+download page and
ways to make it more presentable.

== Proposed fix ==

Re-arrange lots of the data:
* Remove the extra information about verification and just present the help link.
* Move the release date into the header.
* Put 'release notes' and 'changelog' into a collapsible field called 'Release
information'.
* Add '(+) Add download file' under the release table.
* Keep the link at the end for each release but add the series name to it for
distinguishing it.[1]
* Make each release a portlet.[2]

[1] beuno had asked that this entire line be removed. I restored it because if a
release has no download files there is no place to add the '(+) Add download file'
menu link. Releases with no files are just skipped in the body of this page. So it
made sense to bring it back and just list all of the releases in one place. We often
get complaints from users that it is too hard to figure out where to go to add
download files I was hesitant to remove one place they may have grown used to using.

[2] I have made each use the 'top-portlet' class and conditionally insert the border.
This requires less code reorganization than conditionally choosing a class. TAL is
really bad when you need to select attributes conditionally, basically you have to
violate DRY all over the place.

== Pre-implementation notes ==

Lots of discussion with beuno. Unfortunately I have not been able to have a
discussion with mbp but hope to early next week to see if he still has any issues.

== Implementation details ==

As above.

== Tests ==

bin/test -vv -t xx-product-files.txt

== Demo and Q/A ==

https://launchpad.dev/firefox/+download

Also go to any other project and add some releases and download files.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/product-files.pt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/registry/stories/product/xx-product-files.txt
  lib/lp/registry/templates/productrelease-portlet-data.pt

= Summary =

Bug 419742 suggested new information to present on the $product/+download page and
ways to make it more presentable.

== Proposed fix ==

[1] beuno had asked that this entire line be removed.  I restored it because if a
release has no download files there is no place to add the '(+) Add download file'
menu link.  Releases with no files are just skipped in the body of this page.  So it
made sense to bring it back and just list all of the releases in one place.  We often
get complaints from users that it is too hard to figure out where to go to add
download files I was hesitant to remove one place they may have grown used to using.

[2] I have made each use the 'top-portlet' class and conditionally insert the border.
 This requires less code reorganization than conditionally choosing a class.  TAL is
really bad when you need to select attributes conditionally, basically you have to
violate DRY all over the place.

== Pre-implementation notes ==

Lots of discussion with beuno.  Unfortunately I have not been able to have a
discussion with mbp but hope to early next week to see if he still has any issues.

== Implementation details ==

As above.

== Tests ==

bin/test -vv -t xx-product-files.txt

== Demo and Q/A ==

https://launchpad.dev/firefox/+download

Also go to any other project and add some releases and download files.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

« Back to merge proposal