Merge lp:~bac/launchpad/bug-266890 into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | not available |
Merged at revision: | not available |
Proposed branch: | lp:~bac/launchpad/bug-266890 |
Merge into: | lp:launchpad |
Diff against target: |
112 lines (+50/-12) 2 files modified
lib/lp/registry/browser/product.py (+21/-12) lib/lp/registry/browser/tests/product-views.txt (+29/-0) |
To merge this branch: | bzr merge lp:~bac/launchpad/bug-266890 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | code | Approve | |
Review via email: mp+15153@code.launchpad.net |
Commit message
Prevent setting private bugs from causing an OOPS when constraints aren't satisfied.
To post a comment you must log in.
= Summary =
Setting private bugs on the +review-license page for a project with no
bug supervisor set causes an OOPS due to a db constraint.
== Proposed fix ==
Add a test in the form validation to flag the attempt to set private
bugs. I found that the +admin page already does the same thing so the
code was refactored.
== Pre-implementation notes ==
None
== Implementation details ==
As above.
== Tests ==
bin/test -vvt product-views.txt
== Demo and Q/A ==
As mark, go to https:/ /launchpad. dev/firefox/ +review- license and turn on
private bugs. Note the nice error message.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ browser/ product. py registry/ browser/ tests/product- views.txt
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ registry/ browser/ product. py
54: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)