Code review comment for lp:~bac/juju-quickstart/hacking-brew

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Add homebrew release instructions.

Also fixed bad coding in HACKING.rst. Used the 'restview'
package from PyPI to verify it. Replaced long embedded
URLs with references. Looks very nice if rendered but
not as good if read as plaintext.

R=frankban
CC=
https://codereview.appspot.com/106120043

https://codereview.appspot.com/106120043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode215
HACKING.rst:215: #. Compute the SHA1 checksum for the tgz and insert it
as the JujuQuickstart
On 2014/06/18 16:17:24, frankban wrote:
> Juju Quickstart?

Actually brew constructs a Ruby class based on the package name, so in
the file it really is JujuQuickstart.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode221
HACKING.rst:221: download failures are acceptable.)::
On 2014/06/18 16:17:25, frankban wrote:
> are acceptable)

Done.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode221
HACKING.rst:221: download failures are acceptable.)::
On 2014/06/18 16:17:25, frankban wrote:
> are acceptable)

Done.

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode252
HACKING.rst:252: rebase the branch and squash commits before pushing.
I will. This update was flawless and when Jenkins passed the bot merged
it in. Total time was about two hours.

https://codereview.appspot.com/106120043/

« Back to merge proposal