Code review comment for lp:~bac/juju-quickstart/hacking-brew

Revision history for this message
Francesco Banconi (frankban) wrote :

LGTM with minor changes. Thank you!

https://codereview.appspot.com/106120043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode215
HACKING.rst:215: #. Compute the SHA1 checksum for the tgz and insert it
as the JujuQuickstart
Juju Quickstart?

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode221
HACKING.rst:221: download failures are acceptable.)::
are acceptable)

https://codereview.appspot.com/106120043/diff/1/HACKING.rst#newcode252
HACKING.rst:252: rebase the branch and squash commits before pushing.
Could you give a hint about how much time passes between Jenkins tests
pass and the updated formula is merged? Is it merged right after the
tests run?

https://codereview.appspot.com/106120043/

« Back to merge proposal