Merge lp:~bac/juju-gui/hacking into lp:juju-gui/experimental

Proposed by Brad Crittenden
Status: Merged
Merged at revision: 298
Proposed branch: lp:~bac/juju-gui/hacking
Merge into: lp:juju-gui/experimental
Diff against target: 70 lines (+18/-8)
1 file modified
HACKING (+18/-8)
To merge this branch: bzr merge lp:~bac/juju-gui/hacking
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+141747@code.launchpad.net

Description of the change

Update HACKING to reflect current state.

The HACKING document was out-of-date regarding dependencies, required steps,
etc. Following the instructions on a newly installed, non-developer machine
showed the places where packages were missing.

https://codereview.appspot.com/7030056/

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Reviewers: mp+141747_code.launchpad.net,

Message:
Please take a look.

Description:
Update HACKING to reflect current state.

The HACKING document was out-of-date regarding dependencies, required
steps,
etc. Following the instructions on a newly installed, non-developer
machine
showed the places where packages were missing.

https://code.launchpad.net/~bac/juju-gui/hacking/+merge/141747

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7030056/

Affected files:
   M HACKING
   A [revision details]

Index: HACKING
=== modified file 'HACKING'
--- HACKING 2012-12-18 20:31:15 +0000
+++ HACKING 2013-01-03 12:53:38 +0000
@@ -32,11 +32,11 @@

    $ sudo apt-get install python-tz

-The gui frontend can be installed with::
+The gui frontend can be installed and run with::

    $ bzr branch lp:juju-gui trunk
    $ cd trunk
- $ make server
+ $ make prod

  It may take a while for the server to start the first time as npm will
  need to download packages. When ready, the server will print:
@@ -45,9 +45,17 @@

  You can then access the GUI at <http://localhost:8888/>.

-You'll also need to deploy a juju environment with REST api access.
+The front-end needs to talk to a Juju backend. So first you'll need
+to install Juju::
+
+ $ sudo apt-get install juju zookeeper
+
+Next you'll also need to deploy a juju environment with REST api access.
  Currently that work resides in a pipeline of juju branches. The
-recommended branch to use as a server is ``lp:~hazmat/juju/rapi-rollup``.
+recommended branch to use as a server is
+``lp:~hazmat/juju/rapi-rollup``::
+
+ $ bzr branch lp:~hazmat/juju/rapi-rollup

  You can use it with any environment, but for dev purposes, a local
  environment works well. One environment option specific to this branch
@@ -63,6 +71,7 @@
        juju-origin: ppa
        api-port: 8081

+
  Note that juju-origin is set to the ppa, the api server runs outside of
  the container, and it is launched using whichever branch you're using.

@@ -97,19 +106,21 @@
  Running Unit Tests
  ==================

- $ make test
+ $ make test-prod

  Running Lint
  ============

+ $ sudo apt-get install python-virtualenv
    $ make lint

  API Documentation
  =================

-Generated JavaScript documentation is available in the yuidoc directory
after
-running the command ``make yuidoc``. You can view the docs by running::
+Generated JavaScript documentation is available in the yuidoc
+directory. You can view the docs by running::

+ $ make yuidoc
    $ xdg-open yuidoc/index.html

  The `documentation <http://yui.github.com/yuidoc/syntax/>`_ for YUIDoc
markup
@@ -125,7 +136,7 @@

  Build the documentation::

- $ make doc
+ $ make docs

  (This will also generate the above mentioned yuidoc documentation.)

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Revision history for this message
Francesco Banconi (frankban) wrote :

Land as is.

Just a question in the comments below, otherwise, this branch is nice,
thanks.

https://codereview.appspot.com/7030056/diff/1/HACKING
File HACKING (right):

https://codereview.appspot.com/7030056/diff/1/HACKING#newcode74
HACKING:74:
Is this blank line required?

https://codereview.appspot.com/7030056/

Revision history for this message
Nicola Larosa (teknico) wrote :

Land as is (barring the one redundant blank line).

https://codereview.appspot.com/7030056/

lp:~bac/juju-gui/hacking updated
296. By Brad Crittenden

Remove extraneous blank line of doom.

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the reviews.

https://codereview.appspot.com/7030056/diff/1/HACKING
File HACKING (right):

https://codereview.appspot.com/7030056/diff/1/HACKING#newcode74
HACKING:74:
On 2013/01/03 15:21:37, frankban wrote:
> Is this blank line required?

I'm quite fond of that blank line but will honor your request to delete
it.

https://codereview.appspot.com/7030056/

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Update HACKING to reflect current state.

The HACKING document was out-of-date regarding dependencies, required
steps,
etc. Following the instructions on a newly installed, non-developer
machine
showed the places where packages were missing.

R=frankban, teknico
CC=
https://codereview.appspot.com/7030056

https://codereview.appspot.com/7030056/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING'
2--- HACKING 2012-12-18 20:31:15 +0000
3+++ HACKING 2013-01-03 16:15:26 +0000
4@@ -32,11 +32,11 @@
5
6 $ sudo apt-get install python-tz
7
8-The gui frontend can be installed with::
9+The gui frontend can be installed and run with::
10
11 $ bzr branch lp:juju-gui trunk
12 $ cd trunk
13- $ make server
14+ $ make prod
15
16 It may take a while for the server to start the first time as npm will
17 need to download packages. When ready, the server will print:
18@@ -45,9 +45,17 @@
19
20 You can then access the GUI at <http://localhost:8888/>.
21
22-You'll also need to deploy a juju environment with REST api access.
23+The front-end needs to talk to a Juju backend. So first you'll need
24+to install Juju::
25+
26+ $ sudo apt-get install juju zookeeper
27+
28+Next you'll also need to deploy a juju environment with REST api access.
29 Currently that work resides in a pipeline of juju branches. The
30-recommended branch to use as a server is ``lp:~hazmat/juju/rapi-rollup``.
31+recommended branch to use as a server is
32+``lp:~hazmat/juju/rapi-rollup``::
33+
34+ $ bzr branch lp:~hazmat/juju/rapi-rollup
35
36 You can use it with any environment, but for dev purposes, a local
37 environment works well. One environment option specific to this branch
38@@ -97,19 +105,21 @@
39 Running Unit Tests
40 ==================
41
42- $ make test
43+ $ make test-prod
44
45 Running Lint
46 ============
47
48+ $ sudo apt-get install python-virtualenv
49 $ make lint
50
51 API Documentation
52 =================
53
54-Generated JavaScript documentation is available in the yuidoc directory after
55-running the command ``make yuidoc``. You can view the docs by running::
56+Generated JavaScript documentation is available in the yuidoc
57+directory. You can view the docs by running::
58
59+ $ make yuidoc
60 $ xdg-open yuidoc/index.html
61
62 The `documentation <http://yui.github.com/yuidoc/syntax/>`_ for YUIDoc markup
63@@ -125,7 +135,7 @@
64
65 Build the documentation::
66
67- $ make doc
68+ $ make docs
69
70 (This will also generate the above mentioned yuidoc documentation.)
71

Subscribers

People subscribed via source and target branches