Code review comment for lp:~bac/juju-gui/fix-dnd-bundles-wrt-id

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Send bundle id when d'n'd from sidebar.

This path was initially missed. The Token had to be fixed to include
the
ID in the drag data.

Note, for selfish reasons, test/utils.js loadFixtures was updated to
retry on
failures. The reason for the occassional 404 in this function when run
by
lbox is still unknown. Hopefully the dumb retry will help.

QA Instructions:

# Use juju-quickstart trunk
% cd projects/juju-quickstart
% bzr pull
% make
# Deploy on EC2
% juju switch ec2
% .venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-128
% juju set juju-gui
"juju-gui-source=lp:~bac/juju-gui/fix-dnd-bundles-wrt-id"
# May want to wait a bit. Perhaps it isn't necessary.
% juju set juju-gui "charmworld-url=http://staging.jujucharms.com"

Find one of Jorge's bundles on http://staging.jujucharms.com.
(wordpress-simple is a fast one.) Look at the deployment counts.

In the GUI search for 'jorge', find the bundle from above, and *drag* it
onto
the canvas. Have a light snack. When everything is green and happy,
look at
the page again on staging and see that the count has increased by one.
NOTE:
in my QA I didn't see the incremented values reflected immediately which
is
really strange. A few minutes later they were updated.

R=benji
CC=
https://codereview.appspot.com/29960045

https://codereview.appspot.com/29960045/

« Back to merge proposal