Code review comment for lp:~bac/juju-gui/1102640

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

When adding a relation, the service menu is shown.

If adding a relation using the 'Build Relation' action from the service
menu
on the originating service, the click on the target service produces two
events. The dragend event is handled properly and sets up the relation.
  Then
the click event calls serviceClick.

Attempts to use the stopPropagation, stopEvent, and preventDefault
methods on
the d3.event did not produce the desired results.

This work-around is pretty hacky but it does work. A more general
solution
should be found.

Also, attempts to change the test 'must be able to add a relation from
the
service menu' to simulate the click events and ensure the service menu
was not
left displayed did not work.

This branch is submitted as is in an attempt to finish the last card
blocking
the charm announcement.

R=bcsaller
CC=
https://codereview.appspot.com/7179049

https://codereview.appspot.com/7179049/

« Back to merge proposal