Code review comment for lp:~bac/juju-gui/1096230

Revision history for this message
Gary Poster (gary) wrote :

Land with changes.

Looks good to me. Thank you!

Gary

https://codereview.appspot.com/7064060/diff/1/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode276
app/store/env.js:276: * @param {Object} entity The name of a machine,
unit, service, or
Would be nice to specify what the name of these things is--examples.

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode307
app/store/env.js:307: * environment.
You don't describe the keys argument. Given that it appears to be
optional, it would be particularly nice to document.

https://codereview.appspot.com/7064060/

« Back to merge proposal