Code review comment for lp:~bac/juju-gui/1078723

Revision history for this message
Brad Crittenden (bac) wrote :

*** Submitted:

Makefile tweaks

Bug 1078723 addressed problems with changes to third party JS not
forcing a remake of the combined JS files. We really only have one
such file now, the others are handled properly, so this branch adds a
dependency on it, creates a THIRD_PARTY_JS symbol in the Makefile to
make it obvious in the future, and does other clean-up.

I tried removing the special-case for bin/generateTemplates (which
*is* a JavaScript file) by adding a .js extension. That made most of
the make process work but then the linters blew up. I hastily
retreated.

R=benji, frankban
CC=
https://codereview.appspot.com/6873055

https://codereview.appspot.com/6873055/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6873055/diff/1/Makefile#newcode40
Makefile:40: echo $(JSFILES)
gah!
gone.
done.

https://codereview.appspot.com/6873055/

« Back to merge proposal