Code review comment for lp:~bac/charmworld/make-queue-a-job

Reviewers: mp+200027_code.launchpad.net,

Message:
Please take a look.

Description:
Run charm/bundle queue and ingest from one script

Originally, queueing was run from a cronjob every fifteen minutes.
Stuff was
added without regard to it being queued up already.

Ingest was run continuously but slept fifteen minutes when it completed
before
looking at the queue again.

This change makes the supervisord-run worker do the queue job, then
ingest
charms and bundles. At the end, it sleeps for fifteen minutes minus the
amount spent doing the work.

The charmworld charm needs to be fixed to not create the cronjob for
queueing. It hasn't been done yet but the bin/queued script that is
called by
the cronjob needs to be disabled before this change lands or the
queueing will
be run by two different approaches.

https://code.launchpad.net/~bac/charmworld/make-queue-a-job/+merge/200027

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/45440043/

Affected files (+147, -43 lines):
   A [revision details]
   M charmworld/jobs/lp.py
   M charmworld/jobs/tests/test_lp.py
   M charmworld/jobs/tests/test_worker.py
   M charmworld/jobs/worker.py
   M charmworld/testing/__init__.py