Code review comment for lp:~bac/charms/precise/juju-gui/increment-deployments

Revision history for this message
Brad Crittenden (bac) wrote :

Reviewers: mp+195317_code.launchpad.net,

Message:
Please take a look.

Description:
After deploying a bundle increment counter.

The guiserver will make a GET request to the deployment counter
incrementer
URL for the bundle. This required accepting the bundle ID in the
Deployer/Import path.

Note neither the GUI nor quickstart have been updated to pass this value
yet.

The charmworldurl is also now passed to the server via the command line.

QA: just deploy your favorite bundle and see that it works as it should.
  You
can observe the bundle page in charmworld and see the counts remain at
0.

https://code.launchpad.net/~bac/charms/precise/juju-gui/increment-deployments/+merge/195317

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/26740043/

Affected files (+217, -41 lines):
   A [revision details]
   M config/guiserver.conf.template
   M hooks/backend.py
   M hooks/utils.py
   M server/guiserver/apps.py
   M server/guiserver/bundles/__init__.py
   M server/guiserver/bundles/base.py
   M server/guiserver/bundles/utils.py
   M server/guiserver/bundles/views.py
   M server/guiserver/manage.py
   M server/guiserver/tests/bundles/test_base.py
   M server/guiserver/tests/bundles/test_utils.py
   M server/guiserver/tests/bundles/test_views.py
   M server/runserver.py
   M tests/test_backends.py
   M tests/test_utils.py

« Back to merge proposal