lp:~bac/charms/precise/juju-gui/add-lbox

Created by Brad Crittenden and last modified
Get this branch:
bzr branch lp:~bac/charms/precise/juju-gui/add-lbox
Only Brad Crittenden can upload to this branch. If you are Brad Crittenden please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Brad Crittenden
Status:
Development

Recent revisions

63. By Brad Crittenden

Add .lbox for specifying the target branch

62. By Brad Crittenden

Fix the discrepancy between dev and rel branches.

Changes that should've been submitted to the development branch of the gui
(lp:~juju-gui/charms/precise/juju-gui/trunk) were instead merged into the
release branch (lp:charms/juju-gui).

This branch merges those changes back into devel for on-going work. The
premature release will remain in place.

R=teknico
CC=
https://codereview.appspot.com/9975046

61. By Francesco Banconi

Take the juju API address from the environment

The charm now tries to retrieve the juju API
address from the hook context before parsing
the machiner agent file.

This way we take advantage of a change in juju-core
currently in review, which introduces the corresponding
functionality.

R=
CC=
https://codereview.appspot.com/9810044

60. By Nicola Larosa

Describe how to use juju-core in README.md .

Update README.md with instructions specific to juju-core, with regard
to the alternative for the update-to pyjuju command.

R=bac
CC=
https://codereview.appspot.com/9676045

59. By Nicola Larosa

Allow "juju-origin: lp:juju" in env.

Fix charm to work when juju-origin is set to lp:juju in the environment.
QAed with both lp:juju and ppa as values.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/9646043

58. By Francesco Banconi

Support juju-gui-source=branch:revno

Added support for creating and deploying
a release from a specific branch revision.

R=bac, jeff.pihach
CC=
https://codereview.appspot.com/9464043

57. By Nicola Larosa

More charm code cleanup.

Most of these changes were split from the former branch that added
backend unit tests, it was getting too big and unreadable.

No behavior changes, only formatting and two occasions of different
expressions of the same meaning.

R=frankban, gary.poster
CC=
https://codereview.appspot.com/9125046

56. By Francesco Banconi

Fix import errors in stop hook.

This branch includes three trivial fixes:
- stop hook not working;
- using https://manage.jujucharms.com as charmworld URL by default;
- no need to provide credentials in sandbox mode.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/9125043

55. By Nicola Larosa

Add more unit tests to the charm backend.

More unit tests for backend properties, commands and methods.
In order to do that, it mangles the charm code pretty heavily:

- it adds module prefixes to all functions imported by backend.py in order to
  make them monkeypatchable in tests;
- it renames all sub-backends to mixins, for clarity. Arguably, "backend.mixins
  lists all active mixins" is clearer than "backend.backends lists all active
  sub-backends, some of which are actual backends and some others are mixins";
- it simplifies the code in a number of places;
- it removes unused or scarcely used code in backend.py, for simplicity;
- it rephrases some docstrings in more specific terms, for readability;
- it removes the overrideable testing framework in backend.py. It imposes a
  runtime and complexity cost for doing what is already done in other tests by
  monkeypatching;

Further style changes have been moved to a subsequent branch.

It also fixes two import errors.

WARNING: this branch did successfully deploy a stable juju-gui release.
Deploy tests did not run successfully though, and they seem to be broken
in trunk too, right now.

R=bcsaller, frankban
CC=
https://codereview.appspot.com/9121043

54. By Nicola Larosa

Reinstate test symbolic links.

Actually reinstate test symbolic links that were mistakenly
replaced with copies of the linked files.

Trivial, self-reviewed.

R=
CC=
https://codereview.appspot.com/9106044

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:charms/juju-gui
This branch contains Public information 
Everyone can see this information.

Subscribers