Code review comment for lp:~bac/charms/oneiric/buildbot-master/history-s3

Revision history for this message
Gary Poster (gary) wrote :

Hi Brad. That looks good.

You asked about the amount of code needed to stub boto. I am very happy we have it, and I wonder if it ought to be put somewhere else to make it reusable--later, perhaps.

For now, though, the only idea I have is that it might be nice to put the boto setup/teardown stuff in a separate file, just to make the test file easier to read. Just an idea.

Meanwhile though, I approve it again!

review: Approve

« Back to merge proposal