Merge ~b-stolk/chromium-browser/+git/snap-from-source:fix-non-intel-gpu into ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev

Proposed by Bram Stolk
Status: Merged
Approved by: Nathan Teodosio
Approved revision: 230cc25dc8cdb4df36586981c0e1a4f415a798fe
Merged at revision: 230cc25dc8cdb4df36586981c0e1a4f415a798fe
Proposed branch: ~b-stolk/chromium-browser/+git/snap-from-source:fix-non-intel-gpu
Merge into: ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev
Diff against target: 15 lines (+2/-2)
1 file modified
launcher/chromium.launcher (+2/-2)
Reviewer Review Type Date Requested Status
Nathan Teodosio Pending
Review via email: mp+436211@code.launchpad.net

Description of the change

The gpu memory flag still causes NV12 issues on non-intel gpus.
This means it breaks the webcam support.
The chromium launcher cannot enable that option.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/launcher/chromium.launcher b/launcher/chromium.launcher
index 4c79460..53dfcea 100755
--- a/launcher/chromium.launcher
+++ b/launcher/chromium.launcher
@@ -113,8 +113,8 @@ fi
113# Add necessary flags for VAAPI video en/decoding113# Add necessary flags for VAAPI video en/decoding
114CHROMIUM_VAAPI_FLAGS='--enable-features=VaapiVideoDecoder,VaapiVideoEncoder --disable-features=UseChromeOSDirectVideoDecoder --use-gl=egl --video-capture-use-external-dma-buffer'114CHROMIUM_VAAPI_FLAGS='--enable-features=VaapiVideoDecoder,VaapiVideoEncoder --disable-features=UseChromeOSDirectVideoDecoder --use-gl=egl --video-capture-use-external-dma-buffer'
115115
116# With the patch for dynamic NV12 support detection, this should now be safe on non-Intel platforms.116# Still causes issues with PIXEL_FORMAT_NV12 on non-intel GPUs. We cannot enable this here.
117CHROMIUM_VAAPI_FLAGS="--video-capture-use-gpu-memory-buffer $CHROMIUM_VAAPI_FLAGS"117#CHROMIUM_VAAPI_FLAGS="--video-capture-use-gpu-memory-buffer $CHROMIUM_VAAPI_FLAGS"
118118
119if [ -n "$WAYLAND_DISPLAY" ]; then119if [ -n "$WAYLAND_DISPLAY" ]; then
120 CHROMIUM_VAAPI_FLAGS="--ozone-platform=wayland $CHROMIUM_VAAPI_FLAGS"120 CHROMIUM_VAAPI_FLAGS="--ozone-platform=wayland $CHROMIUM_VAAPI_FLAGS"

Subscribers

People subscribed via source and target branches

to status/vote changes: