Chromium Browser

Merge ~b-stolk/chromium-browser/+git/snap-from-source:fix-non-intel-gpu into ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev

  1. Git
  2. lp:~b-stolk/chromium-browser/+git/snap-from-source
  3. fix-non-intel-gpu
  4. Merge into hwacc-dev
Proposed by Bram Stolk
Status: Merged
Approved by: Nathan Teodosio
Approved revision: 230cc25dc8cdb4df36586981c0e1a4f415a798fe
Merged at revision: 230cc25dc8cdb4df36586981c0e1a4f415a798fe
Proposed branch: ~b-stolk/chromium-browser/+git/snap-from-source:fix-non-intel-gpu
Merge into: ~chromium-team/chromium-browser/+git/snap-from-source:hwacc-dev
Diff against target: 15 lines (+2/-2)
1 file modified
launcher/chromium.launcher (+2/-2)
Reviewer Review Type Date Requested Status
Nathan Teodosio Pending
Review via email: mp+436211@code.launchpad.net

Description of the change

The gpu memory flag still causes NV12 issues on non-intel gpus.
This means it breaks the webcam support.
The chromium launcher cannot enable that option.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/launcher/chromium.launcher b/launcher/chromium.launcher
2index 4c79460..53dfcea 100755
3--- a/launcher/chromium.launcher
4+++ b/launcher/chromium.launcher
5@@ -113,8 +113,8 @@ fi
6 # Add necessary flags for VAAPI video en/decoding
7 CHROMIUM_VAAPI_FLAGS='--enable-features=VaapiVideoDecoder,VaapiVideoEncoder --disable-features=UseChromeOSDirectVideoDecoder --use-gl=egl --video-capture-use-external-dma-buffer'
8
9-# With the patch for dynamic NV12 support detection, this should now be safe on non-Intel platforms.
10-CHROMIUM_VAAPI_FLAGS="--video-capture-use-gpu-memory-buffer $CHROMIUM_VAAPI_FLAGS"
11+# Still causes issues with PIXEL_FORMAT_NV12 on non-intel GPUs. We cannot enable this here.
12+#CHROMIUM_VAAPI_FLAGS="--video-capture-use-gpu-memory-buffer $CHROMIUM_VAAPI_FLAGS"
13
14 if [ -n "$WAYLAND_DISPLAY" ]; then
15 CHROMIUM_VAAPI_FLAGS="--ozone-platform=wayland $CHROMIUM_VAAPI_FLAGS"

Subscribers

People subscribed via source and target branches

to status/vote changes: