Code review comment for lp:~azzar1/unity8/launcher-tooltips

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Looks good :)
>
> Some minor stuff
>
> Please mark
> property var hoveredItem:
> property int itemCenter:
> as readonly.
>
> Since you changed a == to === i'll ask you to change tooltipShape.hoveredItem
> == null too, or if you don't want the really really really equal maybe use
> !tooltipShape.hoveredItem ?

Done.

« Back to merge proposal