Unity 8

Code review comment for lp:~azzar1/unity8/launcher-tooltips

  1. launcher-tooltips
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good :)

Some minor stuff

Please mark
 property var hoveredItem:
 property int itemCenter:
as readonly.

Since you changed a == to === i'll ask you to change tooltipShape.hoveredItem == null too, or if you don't want the really really really equal maybe use !tooltipShape.hoveredItem ?

review: Needs Fixing

« Back to merge proposal