Code review comment for lp:~azzar1/unity/lp-1485727

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

Hey, good job! That 2D clipping again... :)

Just a minor "fix": http://pastebin.ubuntu.com/12425108/

It's better to push the Modelview matrix at the end of save_state() to avoid the double call to glMatrixMode. The result will be exactly the same.

Apart from that, cool! :-D

review: Needs Fixing

« Back to merge proposal