Code review comment for lp:~azzar1/unity/launcher-devices-improvement

Revision history for this message
Andrea Azzarone (azzar1) wrote :

===================================================================
1) It should be possible to remove specific file system icons from the Launcher by un-checking the “Keep in Launcher” option (or dragging to the trash).
===================================================================

This branch use the "Keep in Launcher" option but not the dragging to the trash, since there is another bug report (#764905), and my merge proposal, with a different behavior: «Drag and drop a USB key into the trash should eject the USB key».

===================================================================
2) In the case of non-removable file systems, the system should remember these settings so that rebooting will not return these icons to the Launcher.
===================================================================
Ok, this branch does it (at least I hope :)

===================================================================
3) In the case of removable file systems (USB keys, SD cards, etc...), if a removable file system is removed and then re-attached it should re-appear in the Launcher. If the removable file system is not removed and the user has removed it's icon from the Launcher, the icon should not return to the Launcher even if the computer is re-booted.
===================================================================

According to me, this is absurd and make no sense and not so easy to do! :)

===================================================================
4) All 'specific file system' icons that the user has removed from the Launcher should be displayed in the Dash file Lens in the “Favourite Folders/Folders” category. This allows the user to re-add these icons to the Launcher at a later date
===================================================================
According to me this is in part a unity-file-place (???) bug... So first we should add the "specific file system" icons in the Dash file Lens and i cannot (i hate python!) do this.

« Back to merge proposal