Code review comment for lp:~azzar1/unity/fix-839472

Revision history for this message
Tim Penhey (thumper) wrote :

We shouldn't silently pass the tests if not in desktop form factor, but instead use:
  self.skip("Not in desktop form-factor.")

Also, instead of:
  sleep(1);
  self.assertTrue(self.dash.visible)

you can now use Thomi's

  self.assertThat(self.dash.visible, Eventually(Equals(True)))

review: Needs Fixing

« Back to merge proposal