Merge lp:~azzar1/unity/fix-767075 into lp:unity
Proposed by
Andrea Azzarone
Status: | Merged |
---|---|
Merged at revision: | 1240 |
Proposed branch: | lp:~azzar1/unity/fix-767075 |
Merge into: | lp:unity |
Diff against target: |
199 lines (+52/-71) 2 files modified
src/Launcher.cpp (+51/-70) src/Launcher.h (+1/-1) |
To merge this branch: | bzr merge lp:~azzar1/unity/fix-767075 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Smith (community) | Approve | ||
Tim Penhey (community) | Approve | ||
Review via email: mp+63852@code.launchpad.net |
To post a comment you must log in.
Great work.
Even though you didn't change the geometry param, can I get you to fix it please?
SetDndDelta (0, center.y, nux::Geometry (geo.x, geo.y, geo.width, geo.height), current);
should be simplified to
SetDndDelta (0, center.y, geo, current);
We don't need to have yet another constructor.
For bonus points you can change the signature of the SetDndDelta from:
void Launcher: :SetDndDelta (float x, float y, nux::Geometry geo, struct timespec const ¤t)
to
void Launcher: :SetDndDelta( float x, float y, nux::Geometry const& geo, timespec const ¤t)
The const& nux::Geometry parameter means that we don't make an unnecessary copy, and the "struct timespec" can be simplified to just "timespec".