Great work.
Even though you didn't change the geometry param, can I get you to fix it please?
SetDndDelta (0, center.y, nux::Geometry (geo.x, geo.y, geo.width, geo.height), current);
should be simplified to
SetDndDelta (0, center.y, geo, current);
We don't need to have yet another constructor.
For bonus points you can change the signature of the SetDndDelta from:
void Launcher::SetDndDelta (float x, float y, nux::Geometry geo, struct timespec const ¤t)
to
void Launcher::SetDndDelta(float x, float y, nux::Geometry const& geo, timespec const ¤t)
The const& nux::Geometry parameter means that we don't make an unnecessary copy, and the "struct timespec" can be simplified to just "timespec".
« Back to merge proposal
Great work.
Even though you didn't change the geometry param, can I get you to fix it please?
SetDndDelta (0, center.y, nux::Geometry (geo.x, geo.y, geo.width, geo.height), current);
should be simplified to
SetDndDelta (0, center.y, geo, current);
We don't need to have yet another constructor.
For bonus points you can change the signature of the SetDndDelta from:
void Launcher: :SetDndDelta (float x, float y, nux::Geometry geo, struct timespec const ¤t)
to
void Launcher: :SetDndDelta( float x, float y, nux::Geometry const& geo, timespec const ¤t)
The const& nux::Geometry parameter means that we don't make an unnecessary copy, and the "struct timespec" can be simplified to just "timespec".