Merge lp:~azzar1/unity/fix-1089888 into lp:unity

Proposed by Andrea Azzarone
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 2980
Proposed branch: lp:~azzar1/unity/fix-1089888
Merge into: lp:unity
Diff against target: 41 lines (+6/-5)
1 file modified
tests/test_overlay_scrollbar.cpp (+6/-5)
To merge this branch: bzr merge lp:~azzar1/unity/fix-1089888
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+139678@code.launchpad.net

Commit message

Use nux::ObjectPtr(s) in test_overlay_scrollbar.cpp

Description of the change

== Problem ==
TestOverlayScrollBar.TestScrollDownSignal segfaults.

== Fix ==
Use nux::ObjectPtr to handle nux::Object pointers.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Looking good, also - it fixes the segfault for me. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/test_overlay_scrollbar.cpp'
--- tests/test_overlay_scrollbar.cpp 2012-12-11 20:21:45 +0000
+++ tests/test_overlay_scrollbar.cpp 2012-12-13 12:00:51 +0000
@@ -201,11 +201,11 @@
201 MockScrollView(NUX_FILE_LINE_DECL)201 MockScrollView(NUX_FILE_LINE_DECL)
202 : nux::ScrollView(NUX_FILE_LINE_PARAM)202 : nux::ScrollView(NUX_FILE_LINE_PARAM)
203 {203 {
204 scroll_bar_ = std::make_shared<MockScrollBar>(NUX_TRACKER_LOCATION);204 scroll_bar_ = new MockScrollBar(NUX_TRACKER_LOCATION);
205 SetVScrollBar(scroll_bar_.get());205 SetVScrollBar(scroll_bar_.GetPointer());
206 }206 }
207207
208 std::shared_ptr<MockScrollBar> scroll_bar_;208 nux::ObjectPtr<MockScrollBar> scroll_bar_;
209};209};
210210
211class TestOverlayVScrollBar : public Test211class TestOverlayVScrollBar : public Test
@@ -217,7 +217,7 @@
217 scroll_layout_->SetGeometry(0,0,1000,5000);217 scroll_layout_->SetGeometry(0,0,1000,5000);
218 scroll_layout_->SetScaleFactor(0);218 scroll_layout_->SetScaleFactor(0);
219219
220 scroll_view_ = std::make_shared<MockScrollView>(NUX_TRACKER_LOCATION);220 scroll_view_ = new MockScrollView(NUX_TRACKER_LOCATION);
221 scroll_view_->EnableVerticalScrollBar(true);221 scroll_view_->EnableVerticalScrollBar(true);
222 scroll_view_->EnableHorizontalScrollBar(false);222 scroll_view_->EnableHorizontalScrollBar(false);
223 scroll_view_->SetLayout(scroll_layout_);223 scroll_view_->SetLayout(scroll_layout_);
@@ -226,7 +226,7 @@
226 scroll_view_->scroll_bar_->SetContainerSize(0, 0, 202, 400);226 scroll_view_->scroll_bar_->SetContainerSize(0, 0, 202, 400);
227 }227 }
228228
229 std::shared_ptr<MockScrollView> scroll_view_;229 nux::ObjectPtr<MockScrollView> scroll_view_;
230};230};
231231
232TEST_F(TestOverlayWindow, TestOverlayShows)232TEST_F(TestOverlayWindow, TestOverlayShows)
@@ -420,3 +420,4 @@
420}420}
421421
422}422}
423