Code review comment for lp:~azzar1/unity/fix-1003950

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

76 +bamf_mock_window_set_transient (BamfMockWindow *self, BamfWindow* transient)
77 +{
78 + g_return_if_fail (BAMF_IS_MOCK_WINDOW (self));
79 + self->priv->transient = g_object_ref(transient);
80 +}

Mhmh... Probably it's better not to ref it here, since the parent window can be also closed... Probably it's better to add a weak ref instead.

« Back to merge proposal