Code review comment for lp:~azzar1/unity/devices-cleanup-and-test

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Probably I will keep it, since we still need a blacklist for these devices, so for now I'll keep as you wrote it.
Also maybe it's better if you get rid of the "TryTo..." prefix.

Also is this idle still needed:
113 + device_populate_idle_.Run([this] () {
114 PopulateEntries();
115 return false;
116 });

I think it was added to make the launcher controller properly populate the devices, right?
If you confirm this, I'll handle it in another way into my branch.

« Back to merge proposal