Code review comment for lp:~azzar1/unity/custom-bg-color-icon

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi Andy,

Sorry, I didn't see your replies. For future reference, I'd rather you kept data file data in a python string (provided that it's very small, as a desktop file is), and inside the test write that data to a temporary file.

The unit test looks good to me.

review: Approve

« Back to merge proposal