Unity

Code review comment for lp:~azzar1/unity/custom-bg-color-icon

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2012-05-27:

Hi Andy,

A few things need fixing (I bet you never saw that coming!)

std::string DesktopUtilities::GetBackgroundColor(std::string const& desktop_path)

THis ^^ needs to be made const.

nux::Color BamfLauncherIcon::BackgroundColor()

This too.

Do we need better testing? Perhaps something in autopilot?

review: Needs Fixing