Code review comment for lp:~azzar1/unity-lens-files/add-filesystem-icons

Revision history for this message
Paweł Stołowski (stolowski) wrote :

The preview looks fine, but I found a general problem with how uri for device item is constructed: if you plug a device with more than 1 partition, you get same uris for all partitions. I've a usb stick with 2 partitions (each partition has a different name though), and get 2 "device://0012-D687" uris for them. Left clicking on such item in the dash will always activate the same partition; also preview navigation (left/right arrow in the preview) is misbehaving in such case.

review: Needs Fixing

« Back to merge proposal