Merge ~azzar1/ubuntu/+source/gnome-online-accounts:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-online-accounts:ubuntu/master

Proposed by Andrea Azzarone
Status: Merged
Approved by: Sebastien Bacher
Approved revision: b35a7416a5f5d4b6abc78e2aef3f7de6a1e7c5ee
Merged at revision: b35a7416a5f5d4b6abc78e2aef3f7de6a1e7c5ee
Proposed branch: ~azzar1/ubuntu/+source/gnome-online-accounts:ubuntu/master
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-online-accounts:ubuntu/master
Diff against target: 69 lines (+14/-4)
4 files modified
debian/changelog (+10/-0)
debian/control (+1/-1)
debian/control.in (+1/-1)
debian/patches/0002-livepatch-auth.patch (+2/-2)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+353636@code.launchpad.net

Description of the change

Good to go once snapd-glib 1.43 is in cosmic.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The diff is not showing up here due to binary content in the patch but I've look at the changed in the source dir after a quilt push and those make sense, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 10457f0..b2fa1b7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
1gnome-online-accounts (3.29.91-1ubuntu2) UNRELEASED; urgency=medium
2
3 * debian/control*:
4 - Bump libsnapd-glib-dev to (>= 1.43).
5 * debian/patches/0001-ubuntu-sso-provider.patch:
6 - Use SNAPD_ERROR_AUTH_CANCELLED instead of SNAPD_ERROR_PERMISSION_DENIED
7 to understand if Polkit dialog was dimissed by the user.
8
9 -- Andrea Azzarone <andrea.azzarone@canonical.com> Thu, 23 Aug 2018 14:14:36 +0300
10
1gnome-online-accounts (3.29.91-1ubuntu1) cosmic; urgency=medium11gnome-online-accounts (3.29.91-1ubuntu1) cosmic; urgency=medium
212
3 * Merge from Debian experimental (LP: #1788130). Remaining changes:13 * Merge from Debian experimental (LP: #1788130). Remaining changes:
diff --git a/debian/control b/debian/control
index e87492d..c919037 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Build-Depends: debhelper (>= 10.3),
22 libkrb5-dev,22 libkrb5-dev,
23 librest-dev,23 librest-dev,
24 libsecret-1-dev,24 libsecret-1-dev,
25 libsnapd-glib-dev,25 libsnapd-glib-dev (>= 1.43),
26 libsoup2.4-dev (>= 2.42),26 libsoup2.4-dev (>= 2.42),
27 libwebkit2gtk-4.0-dev (>= 2.12.0),27 libwebkit2gtk-4.0-dev (>= 2.12.0),
28 valac28 valac
diff --git a/debian/control.in b/debian/control.in
index b0c213f..a55e15e 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -18,7 +18,7 @@ Build-Depends: debhelper (>= 10.3),
18 libkrb5-dev,18 libkrb5-dev,
19 librest-dev,19 librest-dev,
20 libsecret-1-dev,20 libsecret-1-dev,
21 libsnapd-glib-dev,21 libsnapd-glib-dev (>= 1.43),
22 libsoup2.4-dev (>= 2.42),22 libsoup2.4-dev (>= 2.42),
23 libwebkit2gtk-4.0-dev (>= 2.12.0),23 libwebkit2gtk-4.0-dev (>= 2.12.0),
24 valac24 valac
diff --git a/debian/patches/0001-ubuntu-sso-provider.patch b/debian/patches/0001-ubuntu-sso-provider.patch
index 9c843d4..cf58c55 100644
25Binary files a/debian/patches/0001-ubuntu-sso-provider.patch and b/debian/patches/0001-ubuntu-sso-provider.patch differ25Binary files a/debian/patches/0001-ubuntu-sso-provider.patch and b/debian/patches/0001-ubuntu-sso-provider.patch differ
diff --git a/debian/patches/0002-livepatch-auth.patch b/debian/patches/0002-livepatch-auth.patch
index 99cee8a..dbef190 100644
--- a/debian/patches/0002-livepatch-auth.patch
+++ b/debian/patches/0002-livepatch-auth.patch
@@ -17,7 +17,7 @@ Bug-Ubuntu: https://bugs.launchpad.net/bugs/1752472
17 create mode 100644 data/scripts/lpa_helper.py17 create mode 100644 data/scripts/lpa_helper.py
1818
19diff --git a/configure.ac b/configure.ac19diff --git a/configure.ac b/configure.ac
20index 87ea868..0efbf47 10064420index 176c5b3..de81777 100644
21--- a/configure.ac21--- a/configure.ac
22+++ b/configure.ac22+++ b/configure.ac
23@@ -545,6 +545,7 @@ data/icons/32x32/Makefile23@@ -545,6 +545,7 @@ data/icons/32x32/Makefile
@@ -225,7 +225,7 @@ index 133458a..40a669f 100644
225 -DPACKAGE_SYSCONF_DIR=\""$(sysconfdir)"\" \225 -DPACKAGE_SYSCONF_DIR=\""$(sysconfdir)"\" \
226 -DPACKAGE_DATA_DIR=\""$(pkgdatadir)"\" \226 -DPACKAGE_DATA_DIR=\""$(pkgdatadir)"\" \
227diff --git a/src/goabackend/goaubuntussoprovider.c b/src/goabackend/goaubuntussoprovider.c227diff --git a/src/goabackend/goaubuntussoprovider.c b/src/goabackend/goaubuntussoprovider.c
228index be22a1b..f942cc7 100644228index ca44c01..0ccd7f7 100644
229--- a/src/goabackend/goaubuntussoprovider.c229--- a/src/goabackend/goaubuntussoprovider.c
230+++ b/src/goabackend/goaubuntussoprovider.c230+++ b/src/goabackend/goaubuntussoprovider.c
231@@ -20,6 +20,7 @@231@@ -20,6 +20,7 @@

Subscribers

People subscribed via source and target branches