Merge ~azzar1/ubuntu/+source/gnome-online-accounts:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-online-accounts:ubuntu/master

Proposed by Andrea Azzarone
Status: Merged
Approved by: Sebastien Bacher
Approved revision: b35a7416a5f5d4b6abc78e2aef3f7de6a1e7c5ee
Merged at revision: b35a7416a5f5d4b6abc78e2aef3f7de6a1e7c5ee
Proposed branch: ~azzar1/ubuntu/+source/gnome-online-accounts:ubuntu/master
Merge into: ~ubuntu-desktop/ubuntu/+source/gnome-online-accounts:ubuntu/master
Diff against target: 69 lines (+14/-4)
4 files modified
debian/changelog (+10/-0)
debian/control (+1/-1)
debian/control.in (+1/-1)
debian/patches/0002-livepatch-auth.patch (+2/-2)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+353636@code.launchpad.net

Description of the change

Good to go once snapd-glib 1.43 is in cosmic.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The diff is not showing up here due to binary content in the patch but I've look at the changed in the source dir after a quilt push and those make sense, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 10457f0..b2fa1b7 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+gnome-online-accounts (3.29.91-1ubuntu2) UNRELEASED; urgency=medium
7+
8+ * debian/control*:
9+ - Bump libsnapd-glib-dev to (>= 1.43).
10+ * debian/patches/0001-ubuntu-sso-provider.patch:
11+ - Use SNAPD_ERROR_AUTH_CANCELLED instead of SNAPD_ERROR_PERMISSION_DENIED
12+ to understand if Polkit dialog was dimissed by the user.
13+
14+ -- Andrea Azzarone <andrea.azzarone@canonical.com> Thu, 23 Aug 2018 14:14:36 +0300
15+
16 gnome-online-accounts (3.29.91-1ubuntu1) cosmic; urgency=medium
17
18 * Merge from Debian experimental (LP: #1788130). Remaining changes:
19diff --git a/debian/control b/debian/control
20index e87492d..c919037 100644
21--- a/debian/control
22+++ b/debian/control
23@@ -22,7 +22,7 @@ Build-Depends: debhelper (>= 10.3),
24 libkrb5-dev,
25 librest-dev,
26 libsecret-1-dev,
27- libsnapd-glib-dev,
28+ libsnapd-glib-dev (>= 1.43),
29 libsoup2.4-dev (>= 2.42),
30 libwebkit2gtk-4.0-dev (>= 2.12.0),
31 valac
32diff --git a/debian/control.in b/debian/control.in
33index b0c213f..a55e15e 100644
34--- a/debian/control.in
35+++ b/debian/control.in
36@@ -18,7 +18,7 @@ Build-Depends: debhelper (>= 10.3),
37 libkrb5-dev,
38 librest-dev,
39 libsecret-1-dev,
40- libsnapd-glib-dev,
41+ libsnapd-glib-dev (>= 1.43),
42 libsoup2.4-dev (>= 2.42),
43 libwebkit2gtk-4.0-dev (>= 2.12.0),
44 valac
45diff --git a/debian/patches/0001-ubuntu-sso-provider.patch b/debian/patches/0001-ubuntu-sso-provider.patch
46index 9c843d4..cf58c55 100644
47Binary files a/debian/patches/0001-ubuntu-sso-provider.patch and b/debian/patches/0001-ubuntu-sso-provider.patch differ
48diff --git a/debian/patches/0002-livepatch-auth.patch b/debian/patches/0002-livepatch-auth.patch
49index 99cee8a..dbef190 100644
50--- a/debian/patches/0002-livepatch-auth.patch
51+++ b/debian/patches/0002-livepatch-auth.patch
52@@ -17,7 +17,7 @@ Bug-Ubuntu: https://bugs.launchpad.net/bugs/1752472
53 create mode 100644 data/scripts/lpa_helper.py
54
55 diff --git a/configure.ac b/configure.ac
56-index 87ea868..0efbf47 100644
57+index 176c5b3..de81777 100644
58 --- a/configure.ac
59 +++ b/configure.ac
60 @@ -545,6 +545,7 @@ data/icons/32x32/Makefile
61@@ -225,7 +225,7 @@ index 133458a..40a669f 100644
62 -DPACKAGE_SYSCONF_DIR=\""$(sysconfdir)"\" \
63 -DPACKAGE_DATA_DIR=\""$(pkgdatadir)"\" \
64 diff --git a/src/goabackend/goaubuntussoprovider.c b/src/goabackend/goaubuntussoprovider.c
65-index be22a1b..f942cc7 100644
66+index ca44c01..0ccd7f7 100644
67 --- a/src/goabackend/goaubuntussoprovider.c
68 +++ b/src/goabackend/goaubuntussoprovider.c
69 @@ -20,6 +20,7 @@

Subscribers

People subscribed via source and target branches