Merge lp:~azzar1/software-properties/fix-1762082 into lp:software-properties

Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 1017
Proposed branch: lp:~azzar1/software-properties/fix-1762082
Merge into: lp:software-properties
Diff against target: 63 lines (+22/-5)
3 files modified
debian/changelog (+10/-0)
debian/control (+5/-3)
softwareproperties/SoftwareProperties.py (+7/-2)
To merge this branch: bzr merge lp:~azzar1/software-properties/fix-1762082
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+342854@code.launchpad.net

Commit message

debian/control: Move gir1.2-goa-1.0, gir1.2-secret-1, and gir1.2-snapd-1 dependencies from software-properties-commom to software-properties-gtk (LP: #1762082).

To post a comment you must log in.
1018. By Andrea Azzarone

Wrap "from gi.repository import Snapd" inside a try/except block in order to avoid failures in add-apt-repository.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2018-04-04 07:35:56 +0000
+++ debian/changelog 2018-04-09 19:29:40 +0000
@@ -1,3 +1,13 @@
1software-properties (0.96.24.27) UNRELEASED; urgency=medium
2
3 * debian/control: Move gir1.2-goa-1.0, gir1.2-secret-1,
4 and gir1.2-snapd-1 dependencies from software-properties-common
5 to software-properties-gtk (LP: #1762082).
6 * SoftwareProperties.py: Wrap importing of gir1.2-snapd-1 in a
7 try-except block in order to avoid failures in add-apt-repository.
8
9 -- Andrea Azzarone <andrea.azzarone@canonical.com> Mon, 09 Apr 2018 09:19:23 +0200
10
1software-properties (0.96.24.26) bionic; urgency=medium11software-properties (0.96.24.26) bionic; urgency=medium
212
3 * debian/control:13 * debian/control:
414
=== modified file 'debian/control'
--- debian/control 2018-04-03 15:03:47 +0000
+++ debian/control 2018-04-09 19:29:40 +0000
@@ -41,9 +41,8 @@
41Package: software-properties-common41Package: software-properties-common
42Architecture: all42Architecture: all
43Depends: ${python3:Depends}, ${misc:Depends}, python3,43Depends: ${python3:Depends}, ${misc:Depends}, python3,
44 python3-gi, gir1.2-glib-2.0, gir1.2-goa-1.0 (>= 3.27.92-1ubuntu1), gir1.2-secret-1, gir1.2-snapd-1,44 python3-gi, gir1.2-glib-2.0, python-apt-common (>= 0.9), python3-dbus,
45 python-apt-common (>= 0.9), python3-dbus, python3-software-properties (= ${binary:Version}),45 python3-software-properties (= ${binary:Version}), ca-certificates
46 ca-certificates
47Breaks: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)46Breaks: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)
48Replaces: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)47Replaces: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)
49Description: manage the repositories that you install software from (common)48Description: manage the repositories that you install software from (common)
@@ -60,6 +59,9 @@
60 python3-software-properties (= ${binary:Version}),59 python3-software-properties (= ${binary:Version}),
61 python3-gi,60 python3-gi,
62 gir1.2-gtk-3.0,61 gir1.2-gtk-3.0,
62 gir1.2-goa-1.0 (>= 3.27.92-1ubuntu1),
63 gir1.2-secret-1,
64 gir1.2-snapd-1,
63 python3-aptdaemon.gtk3widgets,65 python3-aptdaemon.gtk3widgets,
64 python3-distro-info,66 python3-distro-info,
65 software-properties-common,67 software-properties-common,
6668
=== modified file 'softwareproperties/SoftwareProperties.py'
--- softwareproperties/SoftwareProperties.py 2018-04-03 14:36:44 +0000
+++ softwareproperties/SoftwareProperties.py 2018-04-09 19:29:40 +0000
@@ -66,8 +66,13 @@
66from . import cloudarchive66from . import cloudarchive
6767
68import gi68import gi
69gi.require_version('Snapd', '1')69from gi.repository import Gio
70from gi.repository import Gio, Snapd70
71try:
72 gi.require_version('Snapd', '1')
73 from gi.repository import Snapd
74except (ImportError, ValueError):
75 pass
7176
72_SHORTCUT_FACTORIES = [77_SHORTCUT_FACTORIES = [
73 ppa.shortcut_handler,78 ppa.shortcut_handler,

Subscribers

People subscribed via source and target branches

to status/vote changes: