Merge lp:~azzar1/software-properties/fix-1762082 into lp:software-properties

Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 1017
Proposed branch: lp:~azzar1/software-properties/fix-1762082
Merge into: lp:software-properties
Diff against target: 63 lines (+22/-5)
3 files modified
debian/changelog (+10/-0)
debian/control (+5/-3)
softwareproperties/SoftwareProperties.py (+7/-2)
To merge this branch: bzr merge lp:~azzar1/software-properties/fix-1762082
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+342854@code.launchpad.net

Commit message

debian/control: Move gir1.2-goa-1.0, gir1.2-secret-1, and gir1.2-snapd-1 dependencies from software-properties-commom to software-properties-gtk (LP: #1762082).

To post a comment you must log in.
1018. By Andrea Azzarone

Wrap "from gi.repository import Snapd" inside a try/except block in order to avoid failures in add-apt-repository.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2018-04-04 07:35:56 +0000
3+++ debian/changelog 2018-04-09 19:29:40 +0000
4@@ -1,3 +1,13 @@
5+software-properties (0.96.24.27) UNRELEASED; urgency=medium
6+
7+ * debian/control: Move gir1.2-goa-1.0, gir1.2-secret-1,
8+ and gir1.2-snapd-1 dependencies from software-properties-common
9+ to software-properties-gtk (LP: #1762082).
10+ * SoftwareProperties.py: Wrap importing of gir1.2-snapd-1 in a
11+ try-except block in order to avoid failures in add-apt-repository.
12+
13+ -- Andrea Azzarone <andrea.azzarone@canonical.com> Mon, 09 Apr 2018 09:19:23 +0200
14+
15 software-properties (0.96.24.26) bionic; urgency=medium
16
17 * debian/control:
18
19=== modified file 'debian/control'
20--- debian/control 2018-04-03 15:03:47 +0000
21+++ debian/control 2018-04-09 19:29:40 +0000
22@@ -41,9 +41,8 @@
23 Package: software-properties-common
24 Architecture: all
25 Depends: ${python3:Depends}, ${misc:Depends}, python3,
26- python3-gi, gir1.2-glib-2.0, gir1.2-goa-1.0 (>= 3.27.92-1ubuntu1), gir1.2-secret-1, gir1.2-snapd-1,
27- python-apt-common (>= 0.9), python3-dbus, python3-software-properties (= ${binary:Version}),
28- ca-certificates
29+ python3-gi, gir1.2-glib-2.0, python-apt-common (>= 0.9), python3-dbus,
30+ python3-software-properties (= ${binary:Version}), ca-certificates
31 Breaks: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)
32 Replaces: python-software-properties (<< 0.85), python3-software-properties (<< 0.85)
33 Description: manage the repositories that you install software from (common)
34@@ -60,6 +59,9 @@
35 python3-software-properties (= ${binary:Version}),
36 python3-gi,
37 gir1.2-gtk-3.0,
38+ gir1.2-goa-1.0 (>= 3.27.92-1ubuntu1),
39+ gir1.2-secret-1,
40+ gir1.2-snapd-1,
41 python3-aptdaemon.gtk3widgets,
42 python3-distro-info,
43 software-properties-common,
44
45=== modified file 'softwareproperties/SoftwareProperties.py'
46--- softwareproperties/SoftwareProperties.py 2018-04-03 14:36:44 +0000
47+++ softwareproperties/SoftwareProperties.py 2018-04-09 19:29:40 +0000
48@@ -66,8 +66,13 @@
49 from . import cloudarchive
50
51 import gi
52-gi.require_version('Snapd', '1')
53-from gi.repository import Gio, Snapd
54+from gi.repository import Gio
55+
56+try:
57+ gi.require_version('Snapd', '1')
58+ from gi.repository import Snapd
59+except (ImportError, ValueError):
60+ pass
61
62 _SHORTCUT_FACTORIES = [
63 ppa.shortcut_handler,

Subscribers

People subscribed via source and target branches

to status/vote changes: